[FW][FIX] purchase_stock: respect manual valuation #197009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR targets 17.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@ethanrobv @adwid ci/runbot failed on this forward-port PR |
**Current behavior:** Invoicing some product at a price unit different from that at reception (with the product having manual valuation and non-standard costing) will create pdiff account move lines on the invoice. **Expected behavior:** With manual valuation, there should not be pdiff AMLs. **Steps to reproduce:** 1. Create a product with average costing and manual valuation 2. Receive 10 units @ $100 to establish some std price 3. Consume the 10 product qty (scrap, sale, ...) 4. Create the invoice on the purchase order 5. Change the price unit on the bill to $120 per product -> post 6. In the journal items tab on the invoice, see the pdiff AMLs **Cause of the issue:** No consideration for valuation when creating the AMLs for pdiff. **Fix:** Check that valuation is `real_time` prior to creating the AMLs. opw-4492217 X-original-commit: d67ea2d
ethanrobv
force-pushed
the
17.0-16.0-opw-4492217-manual-valuation-weird-entries-double-etvi-414559-fw
branch
from
23b4f14 to
55a882a
Compare
|
@ethanrobv @adwid this PR was modified / updated and has become a normal PR. It must be merged directly. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 17, 2025
**Current behavior:** Invoicing some product at a price unit different from that at reception (with the product having manual valuation and non-standard costing) will create pdiff account move lines on the invoice. **Expected behavior:** With manual valuation, there should not be pdiff AMLs. **Steps to reproduce:** 1. Create a product with average costing and manual valuation 2. Receive 10 units @ $100 to establish some std price 3. Consume the 10 product qty (scrap, sale, ...) 4. Create the invoice on the purchase order 5. Change the price unit on the bill to $120 per product -> post 6. In the journal items tab on the invoice, see the pdiff AMLs **Cause of the issue:** No consideration for valuation when creating the AMLs for pdiff. **Fix:** Check that valuation is `real_time` prior to creating the AMLs. opw-4492217 closes #197009 X-original-commit: d67ea2d Signed-off-by: Adrien Widart (awt) <awt@odoo.com> Signed-off-by: Vincent Ethan <etvi@odoo.com>
This was referenced Feb 17, 2025
fw-bot
deleted the
17.0-16.0-opw-4492217-manual-valuation-weird-entries-double-etvi-414559-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
Invoicing some product at a price unit different from that at reception (with the product having manual valuation and non-standard costing) will create pdiff account move lines on the invoice.
Expected behavior:
With manual valuation, there should not be pdiff AMLs.
Steps to reproduce:
Create a product with average costing and manual valuation
Receive 10 units @ $100 to establish some std price
Consume the 10 product qty (scrap, sale, ...)
Create the invoice on the purchase order
Change the price unit on the bill to $120 per product -> post
In the journal items tab on the invoice, see the pdiff AMLs
Cause of the issue:
No consideration for valuation when creating the AMLs for pdiff.
Fix:
Check that valuation is not manual prior to creating the AMLs.
opw-4492217
Forward-Port-Of: #196786