[FW][FIX] purchase_stock: respect manual valuation #197902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@ethanrobv @adwid ci/runbot failed on this forward-port PR |
ethanrobv
force-pushed
the
18.0-16.0-opw-4492217-manual-valuation-weird-entries-double-etvi-416486-fw
branch
from
bd90c3f to
9974dc0
Compare
|
@ethanrobv @adwid this PR was modified / updated and has become a normal PR. It must be merged directly. |
ethanrobv
force-pushed
the
18.0-16.0-opw-4492217-manual-valuation-weird-entries-double-etvi-416486-fw
branch
from
9974dc0 to
c6a6728
Compare
|
@ethanrobv @adwid this forward port of #196786 is awaiting action (not merged or closed). |
|
@robodoo r+ |
|
@ethanrobv @adwid unable to stage: merge conflict |
ethanrobv
force-pushed
the
18.0-16.0-opw-4492217-manual-valuation-weird-entries-double-etvi-416486-fw
branch
from
c6a6728 to
2fe3bb5
Compare
|
@robodoo r+ |
|
@ethanrobv @adwid 'ci/runbot' failed on this reviewed PR. |
**Current behavior:** Invoicing some product at a price unit different from that at reception (with the product having manual valuation and non-standard costing) will create pdiff account move lines on the invoice. **Expected behavior:** With manual valuation, there should not be pdiff AMLs. **Steps to reproduce:** 1. Create a product with average costing and manual valuation 2. Receive 10 units @ $100 to establish some std price 3. Consume the 10 product qty (scrap, sale, ...) 4. Create the invoice on the purchase order 5. Change the price unit on the bill to $120 per product -> post 6. In the journal items tab on the invoice, see the pdiff AMLs **Cause of the issue:** No consideration for valuation when creating the AMLs for pdiff. **Fix:** Check that valuation is `real_time` prior to creating the AMLs. opw-4492217 X-original-commit: 1bd309c
ethanrobv
force-pushed
the
18.0-16.0-opw-4492217-manual-valuation-weird-entries-double-etvi-416486-fw
branch
from
2fe3bb5 to
19121f2
Compare
|
@robodoo r+ |
|
@ethanrobv @adwid 'ci/runbot' failed on this reviewed PR. |
xmo-odoo
deleted the
18.0-16.0-opw-4492217-manual-valuation-weird-entries-double-etvi-416486-fw
branch
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 7, 2025
**Current behavior:** Invoicing some product at a price unit different from that at reception (with the product having manual valuation and non-standard costing) will create pdiff account move lines on the invoice. **Expected behavior:** With manual valuation, there should not be pdiff AMLs. **Steps to reproduce:** 1. Create a product with average costing and manual valuation 2. Receive 10 units @ $100 to establish some std price 3. Consume the 10 product qty (scrap, sale, ...) 4. Create the invoice on the purchase order 5. Change the price unit on the bill to $120 per product -> post 6. In the journal items tab on the invoice, see the pdiff AMLs **Cause of the issue:** No consideration for valuation when creating the AMLs for pdiff. **Fix:** Check that valuation is `real_time` prior to creating the AMLs. opw-4492217 closes odoo/odoo#197902 X-original-commit: 1bd309cec15ab9b0f63e6870397cf7edbc1fa0b1 Signed-off-by: Adrien Widart (awt) <awt@odoo.com> Signed-off-by: Vincent Ethan <etvi@odoo.com>
omar-sherif9992
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 26, 2025
**Current behavior:** Invoicing some product at a price unit different from that at reception (with the product having manual valuation and non-standard costing) will create pdiff account move lines on the invoice. **Expected behavior:** With manual valuation, there should not be pdiff AMLs. **Steps to reproduce:** 1. Create a product with average costing and manual valuation 2. Receive 10 units @ $100 to establish some std price 3. Consume the 10 product qty (scrap, sale, ...) 4. Create the invoice on the purchase order 5. Change the price unit on the bill to $120 per product -> post 6. In the journal items tab on the invoice, see the pdiff AMLs **Cause of the issue:** No consideration for valuation when creating the AMLs for pdiff. **Fix:** Check that valuation is `real_time` prior to creating the AMLs. opw-4492217 closes odoo#197902 X-original-commit: 1bd309c Signed-off-by: Adrien Widart (awt) <awt@odoo.com> Signed-off-by: Vincent Ethan <etvi@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
Invoicing some product at a price unit different from that at reception (with the product having manual valuation and non-standard costing) will create pdiff account move lines on the invoice.
Expected behavior:
With manual valuation, there should not be pdiff AMLs.
Steps to reproduce:
Create a product with average costing and manual valuation
Receive 10 units @ $100 to establish some std price
Consume the 10 product qty (scrap, sale, ...)
Create the invoice on the purchase order
Change the price unit on the bill to $120 per product -> post
In the journal items tab on the invoice, see the pdiff AMLs
Cause of the issue:
No consideration for valuation when creating the AMLs for pdiff.
Fix:
Check that valuation is not manual prior to creating the AMLs.
opw-4492217
Forward-Port-Of: #197009
Forward-Port-Of: #196786