Change the FR_ca translation file #109667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying the putaway rules, if we redirect a package (with a specific type), we don't check the category of the package products. To reproduce the issue: 1. In Settings, enable - Packages - Multi-Step Routes - Storage Categories 2. Edit the warehouse: - Receipt: 2 steps 3. Create three categories C1, C2, C3 - Parent: All 4. Create three locations L1, L2, L3 - Parent: WH/Stock 5. For each location Lx, create a putaway rules PRx: - From: WH/Stock - Category: Cx - To: Lx 6. Create a product P - Type: Storable - Category: C2 7. Create a planned receipt R with 1 x P 8. Mark it as todo, set the done quantity and put it in pack 9. Set a type on the package 10. Mark R as done 11. Open the associated internal transfer Error: the destination location of the package is not L2 -> an incorrect putaway rule has been applied When we try to apply the PR on the SML "input to stock", because this is a package with a type, we don't provide the list of the products. Therefore, we have no idea about the product category. This is a shame in case of a package that contains some products of the same category. We should be able to apply the putaway rules related to that category. Moreover, this commit also fixes two other issues explained in [1] and [2]. The FW of these commits have been stopped for the current one because they didn't fix the above use case. Moreover, this commit simplifies/clarifies the filtering and sorting of all putaway rules [1] 03e47b1 [2] e0098eb OPW-3098452 Part-of: #109570
Before this commit, the byproduct and putaway feature do not work together. More specifically, changing the quantity to produce on a manufacturing order will create automatically a byproduct move line (or update the existing one with the new quantity) but never look for a putaway rule to apply. This commit makes use of `_set_quantity_done()` method on `stock.move` that *do* call the putaway strategy mechanism X-original-commit: 18e55b0 Part-of: #109570
When redirecting the SML of byproducts, the capacity constraints of
the locations are not considered.
To reproduce the issue:
1. In Settings, enable:
- By-Products
- Storage Locations
- Storage Categories
2. Create three storable products P01, P02, P_comp
3. Create a storage category SG:
- Max Weight: 1000
- Capacity by Products:
- 2 x P02
4. Create two locations L01, L02:
- Parent Location: WH/Stock
- Storage Category: SG
5. Create a putaway rule:
- From: WH/Stock
- Product: P02
- To: WH/Stock
- Having Category: SG
6. Create a BoM:
- Product: P01
- Components: 1 x P_compo
- By-products: 1 x P02
7. Update on hand qty of P02:
- 1 x P02 at L01
8. Create and confirm a MO with 2 x P01
9. Set the producing qty to 2
10. Open the detailed operations of P02
Error: The destination location is L01, this would break the
capacity constraint. The location should be L02
When setting the producing qty, we also set the done quantities of
the finished moves and we redirect them thanks to the putaway rules:
https://github.com/odoo/odoo/blob/cc6e31efe6fdd9dee16de1565afe9e1b502de45d/addons/stock/models/stock_move.py#L1885-L1888
However, the SML created only has the `qty_done` defined and, when
applying the putaway rules, we consider the `product_uom_qty` which
is equal to 0 in such a case.
So, when trying to redirect the SML of P02, we check if the capacity
constraint of L01 would be exceeded with the quantity of the SML.
But, as explained above, that quantity will be 0, so we conclude
that the capacity constraint is ok and we return L01 as best solution.
This is the reason why this commit suggests the use of the maximum
between done quantity and reserved quantity. This logic is already
used in the putaway application process, when we check the forecasted
quantity by location:
https://github.com/odoo/odoo/blob/a217ba27600c64c9104f8c1f003afd74ad06bd05/addons/stock/models/stock_location.py#L297-L301
OPW-3100322
closes #109570
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>
Since the rewrite of this dialog, some inconsistent behaviors were present compared to the legacy implementation. This commit fixes some of them. First, many2many fields couldn't be expanded as it was the case before. Secondly, the export list generated by default was wrong, and it has been fixed by this commit. The defaultExportList that was computed in the as expected for the direct export is now also used to display the right fields from the right pane as it ignores the fields that are explicitly not exportable. Finally, minor UI issues have been fixed, like a wrong title. Tests have been added to assert the correct behavior of the dialog when selecting records. closes #109593 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Steps to reproduce : - Open a pos_restaurant session with Print Bill before Payment selected - Add some products - Print a Bill before Payment Bug : The receipt does not show the order date Fix : After that commit, the receipt shows the order date Explanation : The field date.localestring (that appears in the Order Receipt) is computed in the point_of_sale module for the receipt after payment (in Payment Screen) but was not computed in the pos_restaurant for the receipt before payment closes #109623 X-original-commit: d2a0de3 Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
|
|
C3POdoo
requested review from
a team,
Polymorphe57 and
mcm-odoo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the FR_ca translation file for the same translation as FR_BE or FR_FR file,
The canadian file is still in English sometimes
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr