-
Notifications
You must be signed in to change notification settings - Fork 29.9k
[FIX] website_forum: fix redesign layout glitches #129521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, @edi-odoo!
I think we could call it a FIX and target 16.4 for this though as we are very early. What do you think, @tde-banana-odoo ?
Nothing will be "more" broken if only js or css are applied and not the templates anyway.
@flch-odoo @edi-odoo Nobody is using 16.4 as production environment so feel free to fix everything cleanly in that version ... just don't forget to make it move forward so that it lands asap. |
3667379
to
29d1495
Compare
29d1495
to
17b7cde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @edi-odoo .
Here are a couple more things I noticed.
Finally, in this case where the changes are small and isolated in each commit, you may safely squash them into one :)
471e1a5
to
77bc26e
Compare
Hello @tde-banana-odoo , would you please help us make it "move forward so that it lands asap" ? |
@edi-odoo ; If you push again, I'd recommend renaming the commit like "fix redesign layout glitches" or something similar to align with our naming convention (starting with a verb & explicit as possible while keeping short). |
77bc26e
to
d169b3f
Compare
@tde-banana-odoo Up! |
@robodoo delegate=@flch-odoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @edi-odoo ,
I think the changes are still quite limited and safe for 16.4 except for the comment I made.
Could I ask you to apply it and rebase both branches so we can hopefully get rid of the upgrade failure?
- Improve last activity column Allow the columns to resize to fit the date line without wrapping and set the actual date to the title to appear on hover. - Header fixes To avoid the searchbar shrinking too much when there are multiple elements in the header (long title, tag or search filter, ...), we've set a `min-width` to it , and the `max-width` has been moved from the second section of the header to the searchbar instead. The alignment of the title and the rest of the bar is now aligned on the breadcrumb's baseline instead of vertically centered. - Fix dropdown title disappearing on selecting a tag The dropdown's title disappeared when a tag was selected as a filter. - Height of container and aside We've removed the `h-100` on the aside to place it on the parent under the condition that the `forum_welcome_message` has been dismissed. Because `<main>` has a `flex-grow` is applied to it, the `#wrap` has a gap under the content where it doesn't meet the full height of the main. This blank space is made visible by the grey background of the aside. This could be solved by a simple `h-100` on the wrap, but it overflows onto the footer when the `forum_welcome_message` displayed. - Add missing pages names Some titles weren't appearing in the breadcrumb due to misplacement of the `_page_name` t-set or absence of it. - Switch static image for animation The empty moderation pages now have an animated svg instead of a static one. Fun. - Hide filter tool on empty mod pages The moderation pages don't need the filter tool to appear when there are no results. - Switch conditionals `and/or` to `if` Although it works, in python we don't use `X and A or B` but `A if X else B` - Other visual fixes In JS : put back removed classes on voteCount element Tags: fix the overflowing text when tag is long and switch position with icon for more readability Remove useless `not inDropdown` condition on form Fix inverted plural/singular of `Views` Other minor alignment fixes task-3083657 part of task-3316555
d169b3f
to
e43b87b
Compare
Improve last activity column
Allow the columns to resize to fit the date line without wrapping
and set the actual date to the title to appear on hover.
Header fixes
To avoid the searchbar shrinking too much when there are multiple
elements in the header (long title, tag or search filter, ...), we've
set a
min-width
to it , and themax-width
has been movedfrom the second section of the header to the searchbar instead.
The alignment of the title and the rest of the bar is now aligned on the
breadcrumb's baseline instead of vertically centered.
Fix dropdown title disappearing on selecting a tag
The dropdown's title disappeared when a tag was selected as a filter.
Height of container and aside
We've removed the
h-100
on the aside to place it on the parent underthe condition that the
forum_welcome_message
has been dismissed.Because
<main>
has aflex-grow
is applied to it,the
#wrap
has a gap under the content where it doesn't meet the fullheight of the main.
This blank space is made visible by the grey background of the aside.
This could be solved by a simple
h-100
on the wrap, but it overflowsonto the footer when the
forum_welcome_message
displayed.Add missing pages names
Some titles weren't appearing in the breadcrumb due to misplacement of
the
_page_name
t-set or absence of it.Switch static image for animation
The empty moderation pages now have an animated svg instead of a static
one. Fun.
Hide filter tool on empty mod pages
The moderation pages don't need the filter tool to appear when there
are no results.
Switch conditionals
and/or
toif
Although it works, in python we don't use
X and A or B
but
A if X else B
Other visual fixes
In JS : put back removed classes on voteCount element
Tags: fix the overflowing text when tag is long and switch position with
icon for more readability
Remove useless
not inDropdown
condition on formFix inverted plural/singular of
Views
Other minor alignment fixes
task-3083657
part of task-3316555
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr