Skip to content

Conversation

edi-odoo
Copy link
Contributor

@edi-odoo edi-odoo commented Jul 25, 2023

Improve last activity column

Allow the columns to resize to fit the date line without wrapping
and set the actual date to the title to appear on hover.

Header fixes

To avoid the searchbar shrinking too much when there are multiple
elements in the header (long title, tag or search filter, ...), we've
set a min-width to it , and the max-width has been moved
from the second section of the header to the searchbar instead.

The alignment of the title and the rest of the bar is now aligned on the
breadcrumb's baseline instead of vertically centered.

Fix dropdown title disappearing on selecting a tag

The dropdown's title disappeared when a tag was selected as a filter.

Height of container and aside

We've removed the h-100 on the aside to place it on the parent under
the condition that the forum_welcome_message has been dismissed.

Because <main> has a flex-grow is applied to it,
the #wrap has a gap under the content where it doesn't meet the full
height of the main.
This blank space is made visible by the grey background of the aside.
This could be solved by a simple h-100 on the wrap, but it overflows
onto the footer when the forum_welcome_message displayed.

Add missing pages names

Some titles weren't appearing in the breadcrumb due to misplacement of
the _page_name t-set or absence of it.

Switch static image for animation

The empty moderation pages now have an animated svg instead of a static
one. Fun.

Hide filter tool on empty mod pages

The moderation pages don't need the filter tool to appear when there
are no results.

Switch conditionals and/or to if

Although it works, in python we don't use X and A or B
but A if X else B

Other visual fixes

In JS : put back removed classes on voteCount element
Tags: fix the overflowing text when tag is long and switch position with
icon for more readability
Remove useless not inDropdown condition on form
Fix inverted plural/singular of Views

Other minor alignment fixes

task-3083657
part of task-3316555


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@edi-odoo edi-odoo requested a review from flch-odoo July 25, 2023 09:33
@robodoo
Copy link
Contributor

robodoo commented Jul 25, 2023

Pull request status dashboard

@C3POdoo C3POdoo added the RD research & development, internal work label Jul 25, 2023
Copy link
Contributor

@flch-odoo flch-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, @edi-odoo!
I think we could call it a FIX and target 16.4 for this though as we are very early. What do you think, @tde-banana-odoo ?
Nothing will be "more" broken if only js or css are applied and not the templates anyway.

@tde-banana-odoo
Copy link
Contributor

tde-banana-odoo commented Jul 31, 2023

@flch-odoo @edi-odoo Nobody is using 16.4 as production environment so feel free to fix everything cleanly in that version ... just don't forget to make it move forward so that it lands asap.

@edi-odoo edi-odoo force-pushed the master-forum-pimp-and-pump-edi branch 2 times, most recently from 3667379 to 29d1495 Compare August 2, 2023 11:22
@edi-odoo edi-odoo changed the base branch from master to saas-16.4 August 2, 2023 11:23
@edi-odoo edi-odoo force-pushed the master-forum-pimp-and-pump-edi branch from 29d1495 to 17b7cde Compare August 2, 2023 11:24
@edi-odoo edi-odoo changed the title [IMP] website_forum: post revamp design fixes [FIX] website_forum: post revamp design fixes Aug 2, 2023
Copy link
Contributor

@flch-odoo flch-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @edi-odoo .
Here are a couple more things I noticed.
Finally, in this case where the changes are small and isolated in each commit, you may safely squash them into one :)

@edi-odoo edi-odoo force-pushed the master-forum-pimp-and-pump-edi branch 2 times, most recently from 471e1a5 to 77bc26e Compare August 7, 2023 10:29
@edi-odoo edi-odoo marked this pull request as ready for review August 7, 2023 10:30
@C3POdoo C3POdoo requested a review from a team August 7, 2023 10:32
@flch-odoo
Copy link
Contributor

Hello @tde-banana-odoo , would you please help us make it "move forward so that it lands asap" ?

@flch-odoo
Copy link
Contributor

@edi-odoo ; If you push again, I'd recommend renaming the commit like "fix redesign layout glitches" or something similar to align with our naming convention (starting with a verb & explicit as possible while keeping short).

@edi-odoo edi-odoo force-pushed the master-forum-pimp-and-pump-edi branch from 77bc26e to d169b3f Compare August 7, 2023 12:38
@edi-odoo edi-odoo changed the title [FIX] website_forum: post revamp design fixes [FIX] website_forum: fix redesign layout glitches Aug 7, 2023
@flch-odoo
Copy link
Contributor

@tde-banana-odoo Up!

@tde-banana-odoo
Copy link
Contributor

@robodoo delegate=@flch-odoo

Copy link
Contributor

@flch-odoo flch-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @edi-odoo ,
I think the changes are still quite limited and safe for 16.4 except for the comment I made.
Could I ask you to apply it and rebase both branches so we can hopefully get rid of the upgrade failure?

- Improve last activity column
Allow the columns to resize to fit the date line without wrapping
and set the actual date to the title to appear on hover.

- Header fixes
To avoid the searchbar shrinking too much when there are multiple
elements in the header (long title, tag or search filter, ...), we've
set a `min-width` to it , and the `max-width` has been moved
from the second section of the header to the searchbar instead.

The alignment of the title and the rest of the bar is now aligned on the
breadcrumb's baseline instead of vertically centered.

- Fix dropdown title disappearing on selecting a tag
The dropdown's title disappeared when a tag was selected as a filter.

- Height of container and aside
We've removed the `h-100` on the aside to place it on the parent under
the condition that the `forum_welcome_message` has been dismissed.

Because `<main>` has a `flex-grow` is applied to it,
the `#wrap` has a gap under the content where it doesn't meet the full
height of the main.
This blank space is made visible by the grey background of the aside.
This could be solved by a simple `h-100` on the wrap, but it overflows
onto the footer when the `forum_welcome_message` displayed.

- Add missing pages names
Some titles weren't appearing in the breadcrumb due to misplacement of
the `_page_name` t-set or absence of it.

- Switch static image for animation
The empty moderation pages now have an animated svg instead of a static
one. Fun.

- Hide filter tool on empty mod pages
The moderation pages don't need the filter tool to appear when there
are no results.

- Switch conditionals `and/or` to `if`

Although it works, in python we don't use `X and A or B`
but `A if X else B`

- Other visual fixes

In JS : put back removed classes on voteCount element
Tags: fix the overflowing text when tag is long and switch position with
icon for more readability
Remove useless `not inDropdown` condition on form
Fix inverted plural/singular of `Views`

Other minor alignment fixes

task-3083657
part of task-3316555
@edi-odoo edi-odoo force-pushed the master-forum-pimp-and-pump-edi branch from d169b3f to e43b87b Compare August 17, 2023 09:09
@flch-odoo
Copy link
Contributor

Looks good, thank you for the fixes, @edi-odoo !

@robodoo r+

@robodoo robodoo temporarily deployed to merge August 17, 2023 13:50 Inactive
@robodoo robodoo closed this Aug 17, 2023
@fw-bot fw-bot deleted the master-forum-pimp-and-pump-edi branch August 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants