[FIX] point_of_sale: hide cash move button for use without permission #130275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hubvd
force-pushed
the
16.0-opw-3333622-huvw
branch
3 times, most recently
from
ea71e6b to
086e5a4
Compare
Steps to reproduce ================== - Remove the Accounting/Billing permission from Marc Demo - Login as Marc Demo - Start a POS session - Click on "Cash In/Out" An error occurs because the user doesn't have the appropriate permission Solution ======== Add a key `has_cash_move_permission` in the pos config. Set it to the presence/absence of the group `account.group_account_invoice`. If the permission is missing, hide the "Cash In/Out" button. opw-3333622
hubvd
force-pushed
the
16.0-opw-3333622-huvw
branch
from
086e5a4 to
ec3151f
Compare
C3POdoo
requested review from
a team and
rhe-odoo
and removed request for
a team
|
@caburj What do you think ? |
robinengels
approved these changes
Aug 7, 2023
|
@robodoo r+ |
This was referenced Aug 10, 2023
6 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
An error occurs because the user doesn't have the appriopriate permission
Solution
When loading the pos data, set cash_control to False when the permission is missing.
opw-3333622