-
Notifications
You must be signed in to change notification settings - Fork 29.9k
[FW][FIX] pos_mrp: fix COGS with kit made of kit #142315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fw-bot
wants to merge
1
commit into
odoo:master
from
odoo-dev:master-15.0-opw-3548604-cogs-kit-of-kit-roen-sj-2-fw
Closed
[FW][FIX] pos_mrp: fix COGS with kit made of kit #142315
fw-bot
wants to merge
1
commit into
odoo:master
from
odoo-dev:master-15.0-opw-3548604-cogs-kit-of-kit-roen-sj-2-fw
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@robinengels @vlst-odoo cherrypicking of pull request #141512 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
42ec43f
to
53119a7
Compare
@robodoo r+ |
53119a7
to
b048b80
Compare
Current behavior: When you sell a kit made of kit, the COGS are not registered correctly in the invoice. Steps to reproduce: - Create Kit A with product A - Create Kit B with product B - Create Kit Final with kit A and kit B - Make sure the Category of the products is in FIFO automated - Open PoS, and sell Kit Final and invoice it. - Go in the backend, and check the invoice lines of the order. - The COGS of the products are not registered correctly. Note: This was happening because the price unit of the kit was not calculated correctly. Because when the product was a kit made of kit, the bom was not exploded to consider all the components of the kit. opw-3548604 X-original-commit: c862d3f
b048b80
to
967ee08
Compare
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 22, 2023
Current behavior: When you sell a kit made of kit, the COGS are not registered correctly in the invoice. Steps to reproduce: - Create Kit A with product A - Create Kit B with product B - Create Kit Final with kit A and kit B - Make sure the Category of the products is in FIFO automated - Open PoS, and sell Kit Final and invoice it. - Go in the backend, and check the invoice lines of the order. - The COGS of the products are not registered correctly. Note: This was happening because the price unit of the kit was not calculated correctly. Because when the product was a kit made of kit, the bom was not exploded to consider all the components of the kit. opw-3548604 closes #142315 X-original-commit: c862d3f Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com> Signed-off-by: Robin Engels (roen) <roen@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
17.1
conflict
There was an error while creating this forward-port PR
forwardport
This PR was created by @fw-bot
OE
the report is linked to a support ticket (opw-...)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
When you sell a kit made of kit, the COGS are not registered correctly in the invoice.
Steps to reproduce:
Note:
This was happening because the price unit of the kit was not calculated correctly. Because when the product was a kit made of kit, the bom was not exploded to consider all the components of the kit.
opw-3548604
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #142246
Forward-Port-Of: #141512