Skip to content

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Nov 16, 2023

Current behavior:
When you sell a kit made of kit, the COGS are not registered correctly in the invoice.

Steps to reproduce:

  • Create Kit A with product A
  • Create Kit B with product B
  • Create Kit Final with kit A and kit B
  • Make sure the Category of the products is in FIFO automated
  • Open PoS, and sell Kit Final and invoice it.
  • Go in the backend, and check the invoice lines of the order.
  • The COGS of the products are not registered correctly.

Note:
This was happening because the price unit of the kit was not calculated correctly. Because when the product was a kit made of kit, the bom was not exploded to consider all the components of the kit.

opw-3548604

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #142246
Forward-Port-Of: #141512

@robodoo
Copy link
Contributor

robodoo commented Nov 16, 2023

Pull request status dashboard.

@fw-bot
Copy link
Contributor Author

fw-bot commented Nov 16, 2023

@robinengels @vlst-odoo cherrypicking of pull request #141512 failed.

stdout:

Auto-merging addons/pos_mrp/tests/test_pos_mrp_flow.py
CONFLICT (content): Merge conflict in addons/pos_mrp/tests/test_pos_mrp_flow.py

stderr:

14:21:30.365989 git.c:463               trace: built-in: git cherry-pick cf1a8966806b1947c631f15393e3a16744b7993e
error: could not apply cf1a8966806b... [FIX] pos_mrp: fix COGS with kit made of kit
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Nov 16, 2023
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Nov 16, 2023
@robinengels robinengels force-pushed the master-15.0-opw-3548604-cogs-kit-of-kit-roen-sj-2-fw branch from 42ec43f to 53119a7 Compare November 17, 2023 11:20
@robinengels
Copy link
Contributor

@robodoo r+

@C3POdoo C3POdoo requested review from a team and caburj and removed request for a team November 17, 2023 11:22
@robinengels robinengels force-pushed the master-15.0-opw-3548604-cogs-kit-of-kit-roen-sj-2-fw branch from 53119a7 to b048b80 Compare November 20, 2023 10:11
Current behavior:
When you sell a kit made of kit, the COGS are not registered correctly
in the invoice.

Steps to reproduce:
- Create Kit A with product A
- Create Kit B with product B
- Create Kit Final with kit A and kit B
- Make sure the Category of the products is in FIFO automated
- Open PoS, and sell Kit Final and invoice it.
- Go in the backend, and check the invoice lines of the order.
- The COGS of the products are not registered correctly.

Note:
This was happening because the price unit of the kit was not calculated
correctly. Because when the product was a kit made of kit, the bom was
not exploded to consider all the components of the kit.

opw-3548604

X-original-commit: c862d3f
@robinengels robinengels force-pushed the master-15.0-opw-3548604-cogs-kit-of-kit-roen-sj-2-fw branch from b048b80 to 967ee08 Compare November 22, 2023 11:44
@robinengels
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 22, 2023
Current behavior:
When you sell a kit made of kit, the COGS are not registered correctly
in the invoice.

Steps to reproduce:
- Create Kit A with product A
- Create Kit B with product B
- Create Kit Final with kit A and kit B
- Make sure the Category of the products is in FIFO automated
- Open PoS, and sell Kit Final and invoice it.
- Go in the backend, and check the invoice lines of the order.
- The COGS of the products are not registered correctly.

Note:
This was happening because the price unit of the kit was not calculated
correctly. Because when the product was a kit made of kit, the bom was
not exploded to consider all the components of the kit.

opw-3548604

closes #142315

X-original-commit: c862d3f
Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
@robodoo robodoo closed this Nov 22, 2023
@robodoo robodoo added the 17.1 label Nov 22, 2023
@fw-bot fw-bot deleted the master-15.0-opw-3548604-cogs-kit-of-kit-roen-sj-2-fw branch December 6, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.1 conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants