[FW][FIX] account: allow users to see products after configuring taxes

[fw-bot]

The account module adds the tax_string field to product forms:

odoo/addons/account/views/product_view.xml

Line 76 in ceb8b78

<span class="ml-2"/><field name="tax_string"/>

That field calls Model(account.tax).compute_all():

odoo/addons/account/models/product.py

Line 71 in ceb8b78

res = self.taxes_id.compute_all(price, product=self, partner=self.env['res.partner'])

That method needs access to account.account.tag records:

odoo/addons/account/models/account_tax.py

Line 563 in ceb8b78

product_tag_ids = product.account_tag_ids.ids if product else []

odoo/addons/account/models/account_tax.py

Line 632 in ceb8b78

repartition_line_tags = repartition_line.tag_ids

odoo/addons/account/models/account_tax.py

Line 648 in ceb8b78

'tag_ids': (repartition_line_tags + subsequent_tags).ids + product_tag_ids,

odoo/addons/account/models/account_tax.py

Line 671 in ceb8b78

'base_tags': base_rep_lines.tag_ids.ids + product_tag_ids,

Internal users were able to read account.tax and account.tax.repartition.line records, but they couldn't read account.account.tag records.

So, this lead to the absurd situation where a user with permissions to read products (like stock, PoS or event users) couldn't be able to see the product form anymore whenever that product happened to have a tax with a repartition line with a tag:

2023-12-12.11-59-50.mp4

This is a regression from Odoo 14, introduced in #74138 and #73602.

I'm granting all internal users read permission over account.account.tag, just like the one they have for account.tax and account.tax.repartition.line. BTW that's the fix suggested by Odoo helpdesk.

@moduon MT-4390
OPW-3636032

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #149306
Forward-Port-Of: #146787

[robodoo]

.

[fw-bot]

@yajo @csnauwaert cherrypicking of pull request #146787 failed.

stdout:

Auto-merging addons/account/security/ir.model.access.csv
Auto-merging addons/account/tests/__init__.py
Auto-merging addons/mrp/models/product.py
CONFLICT (content): Merge conflict in addons/mrp/models/product.py

stderr:

17:33:12.718982 git.c:463               trace: built-in: git cherry-pick 4b286e9820c61fcda55d1a51f1a6fbd163005a93
error: could not apply 4b286e9820c6... [FIX] account: allow users to see products after configuring taxes
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[csnauwaert]

@robodoo r+