[FIX] lunch: prevent indexerror when deleting topping

[reka-odoo]

When the user tries to delete the toppings,
a traceback appears.

Steps to reproduce the error:

• Go to Lunch > Configuration > Vendors > Open any vendor
• Now add extra 2 (topping 2) > Save
• Delete that extra 2 (topping 2) > Save

Traceback:

IndexError: list index out of range
  File "odoo/http.py", line 2251, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1827, in _serve_db
    return self._transactioning(_serve_ir_http, readonly=ro)
  File "odoo/http.py", line 1847, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1825, in _serve_ir_http
    return self._serve_ir_http(rule, args)
  File "odoo/http.py", line 1832, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 2057, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 220, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 739, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 38, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "addons/web/controllers/dataset.py", line 34, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 458, in call_kw
    result = getattr(recs, name)(*args, **kwargs)
  File "addons/web/models/models.py", line 71, in web_save
    self.write(vals)
  File "addons/lunch/models/lunch_supplier.py", line 193, in write
    topping_values = topping[2]

odoo/addons/lunch/models/lunch_supplier.py

Lines 192 to 193 in 07f6d71

	for topping in values.get('topping_ids_2', []):
	topping_values = topping[2]

Here when the user deletes the extra 2 (topping 2),
"topping" will be [2,2] instead of [2,2,False].
So when it tries to access topping[2],
It will lead to the above traceback.

sentry-5203693767

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

.

[reka-odoo]

Hello @odoo/sentry_reviewers 👋
Please review this PR.
Thanks!

[abla001]

LGTM

[abla001]

make the comments above the lines

[reka-odoo]

make the comments above the lines

Done.

[reka-odoo]

Hello @sofiagvaladze 👋
Can you review this PR?
Thanks!

[sofiagvaladze]

robodoo r+