[FIX] hr_recruitment: use context lang for partner creation

[nd-dew]

[FIX] hr_recruitment: use context lang for partner creation

When partner is created from Applicant's email_from inverse, in a situation when
job application is submitted, we should use context lang for him.

Useful when submiting application for multi-lang website and becuase
partner's lang is used to send appropriate translations of recruitment
templates.

[Reproduce Original Error]

• Install website,hr_recruitment
• Set couple of languages on the website (e.g., en_US as default, es_MX as the second language).
• In incognito, using non-default language, apply for some position (url: /es_MX/jobs )
• BUG: The email sent to the applicant is in the default language

opw-3984176

[robodoo]

[nd-dew]

test_layout_email_lang_template fails because template takes lang from mail.test.lang here:

def render_inline_template(template_instructions, variables):
    results = []
    for string, expression in template_instructions:
        results.append(string)

        if expression:
            result = safe_eval.safe_eval(expression, variables)  <--- HERE lang is taken from the mail.test.lang object
            if result:
                results.append(str(result))

    return ''.join(results)

and adds it to the context here in MailRenderMixin._classify_per_lang:

odoo/addons/mail/models/mail_render_mixin.py

Lines 573 to 584 in 677f7d0

	self.ensure_one()
	if self.env.context.get('template_preview_lang'):
	lang_to_res_ids = {self.env.context['template_preview_lang']: res_ids}
	else:
	lang_to_res_ids = {}
	for res_id, lang in self._render_lang(res_ids, engine=engine).items():
	lang_to_res_ids.setdefault(lang, []).append(res_id)
	return dict(
	(lang, (self.with_context(lang=lang) if lang else self, lang_res_ids))
	for lang, lang_res_ids in lang_to_res_ids.items()

[nle-odoo]

looks good to me

when there is a parent partner, we are doing in the _onchange_parent_id_for_lang:

odoo/odoo/addons/base/models/res_partner.py

Line 488 in 677f7d0

self.lang = self.parent_id.lang or self.env.context.get('default_lang') or self.env.lang

(self.env.lang is a shortcut to self.env.context.get('lang') (that also has a check to see if this is a valid language))

so it seems ok to also have a similar fallback when there is no parent partner.

probably we should also handle the default_lang with higher priority than context lang, because currently this could be working like this and people could be using default_lang with the context having another language.

[nle-odoo]

sorry, looking more at it, I see that the lang should already defined in python at:

https://github.com/odoo/odoo/blob/77f4b70552feb536a6edc33f6fc4ad24c5e8d5ff/odoo/addons/base/models/res_partner.py#L188-L189

so I'm not sure how this doesn't work, since we should already fallback on the context lang (self.env.lang) if there is no default_lang in context (that would be in values.get('lang') coming from the super call to default_get.

edit: oh maybe in this flow we don't use the default_get. If it's the case, then maybe:

• this flow should use (not sure where maybe in website/hr_recruitement/ mail / ...) default_get or set default_lang in context itself
• or a change like in this PR (in base) should be done

[nd-dew]

Experiment: Remove ir_default tz -> Fail

Removing default timezone ir_default table with:

diff --git a/odoo/addons/base/models/res_lang.py b/odoo/addons/base/models/res_lang.py
--- a/odoo/addons/base/models/res_lang.py
+++ b/odoo/addons/base/models/res_lang.py
@@ -202,7 +202,6 @@ class Lang(models.Model):
         IrDefault = self.env['ir.default']
         default_value = IrDefault._get('res.partner', 'lang')
         if default_value is None:
-            IrDefault.set('res.partner', 'lang', lang_code)

... solves the issue, because then default_get will grab language from the context.
BUT too many things depends on the default lang beeing in the ir_default table, so this broke too many tests
Reverting....

[nd-dew]

Experiment 2: reorder default_get lang -> works but too wide

So it doens't make sense that getting value base default get is first
because afaik it will always have lang from the ir_default. ihmo we
should take higher granuality first, so the context lang, later from
parent, and last from the database

[nd-dew]

Narrowing down...

...to hr_recruitment module, to the partner creation from email_from inverse

[Bertrand2]

Thanks for the fix!
The fix seems to work, so aside from my comment, LGTM! :)

[Bertrand2]

I think it's best that you ensure that more than 2 languages are installed rather than having a check for it, and same for the default as well :)

[nd-dew]

True, thanks for having a look ;)

[nle-odoo]

robodoo delegate+

[Bertrand2]

robodoo r+