[FIX] website: fix scrolling issue on mobile devices #189337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bvr-odoo
force-pushed
the
18.0-fix-blocked-scroll-down-bvr
branch
from
3a6efd5 to
b6b287e
Compare
bvr-odoo
force-pushed
the
18.0-fix-blocked-scroll-down-bvr
branch
from
b6b287e to
c40ec55
Compare
qsm-odoo
requested changes
Dec 5, 2024
bvr-odoo
force-pushed
the
18.0-fix-blocked-scroll-down-bvr
branch
from
c40ec55 to
5a99628
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Since commit [1], where the frontend scrolling was moved back out of the '#wrapwrap', an issue sometimes occurs with the standard effect when scrolling on mobile page. Steps to reproduce: - Go to a website with "e-commerce" installed. - Use the devtools to display the website on a mobile device (note that the bug may only occur on certain mobile devices, so it might be necessary to test several to reproduce it). - Add a product to the cart and go to the "/shop/checkout" page. - Try scrolling down. - Bug: scrolling is blocked. The bug happens because, when the page starts scrolling with the "standard" header, there’s a short moment when the header has a "translate: transform" applied but is not yet "affixed." This creates a new coordinate system for the header and affects its child elements, like the "off-canvas mobile" navbar. As a result, the "off-canvas mobile" navbar temporarily changes the page size, which causes scrolling issues, especially on mobile devices. To fix this, we add "display: none" to the "off-canvas mobile" navbar during this short moment so it no longer affects the page size. [1]: odoo@189a7c9 opw-4303667 opw-4305493
bvr-odoo
force-pushed
the
18.0-fix-blocked-scroll-down-bvr
branch
from
5a99628 to
f129e8e
Compare
qsm-odoo
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit [1], where the frontend scrolling was moved back out of the
'#wrapwrap', an issue sometimes occurs with the standard effect when
scrolling on mobile page.
Steps to reproduce:
the bug may only occur on certain mobile devices, so it might be
necessary to test several to reproduce it).
The bug happens because, when the page starts scrolling with the
"standard" header, there’s a short moment when the header has a
"translate: transform" applied but is not yet "affixed." This creates a
new coordinate system for the header and affects its child elements,
like the "off-canvas mobile" navbar. As a result, the
"off-canvas mobile" navbar temporarily changes the page size, which
causes scrolling issues, especially on mobile devices.
To fix this, we add "display: none" to the "off-canvas mobile" navbar
during this short moment so it no longer affects the page size.
opw-4303667
opw-4305493