[FIX] hr: fixed the plan smart button #190938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kais-odoo
requested changes
Dec 25, 2024
yava-odoo
force-pushed
the
17.0-hr-department-activity-plans-yava
branch
from
2efd062 to
03f1287
Compare
yava-odoo
force-pushed
the
17.0-hr-department-activity-plans-yava
branch
from
03f1287 to
ff8c166
Compare
addons/hr/models/hr_department.py
Outdated
Comment on lines
135
to
147
There was a problem hiding this comment.
The domain should have the '|' right?
Suggested change
| domain = [ | |
| ('department_id', '=', False), | |
| ('department_id', '=', self.id), | |
| ] | |
| domain = [ | |
| '|', | |
| ('department_id', '=', False), | |
| ('department_id', '=', self.id), | |
| ] |
There was a problem hiding this comment.
Opps 🙈
I've fixed it 😇
There was a problem hiding this comment.
Hello Yash, the number of plans on the button on the department form view doesn't take into account the plans whose department is False. I know it wasn't part of the spec but I've discussed that with Sumanth and given that we show these plans, then the count should be updated.
yava-odoo
force-pushed
the
17.0-hr-department-activity-plans-yava
branch
3 times, most recently
from
84ff9f0 to
70f70d7
Compare
yava-odoo
force-pushed
the
17.0-hr-department-activity-plans-yava
branch
from
70f70d7 to
3d21ba9
Compare
In this commit, - Set the default department for the Plans smart button. - If there is no plan, it will open the form view. Task-4356557
tivisse
force-pushed
the
17.0-hr-department-activity-plans-yava
branch
from
3d21ba9 to
6fb298b
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 3, 2025
In this commit, - Set the default department for the Plans smart button. - If there is no plan, it will open the form view. Task-4356557 closes #190938 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
|
@yava-odoo @tivisse staging failed: ci/runbot on b47d0b74595d1142eb857950a6f63b42c91ad630 (view more at https://runbot.odoo.com/runbot/build/74443264) |
|
@robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Feb 4, 2025
In this commit, - Set the default department for the Plans smart button. - If there is no plan, it will open the form view. Task-4356557 closes #190938 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
Task-4356557