[FW][FIX] payment_mercado_pago: round payment tx amounts for COP, HLN & NIO #191214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions -------- - 17.0+ Steps ----- 1. Use COP, HLN or NIO as currency; 2. create a SO or invoice with a non-integer amount total; 3. create a payment link; 4. pay using Mercado Pago. Issue ----- > Error processing payment > Prices in COP currency must be expressed with integer values Cause ----- Our currency defaults follow the ISO 4217 standard for minor units. For three currencies (COP, HLN & NIO), Mercado Pago only accepts integer amounts instead of the standard 2 decimals, resulting in a failed payment transaction. Solution -------- In the payload sent to Mercado Pago, round the amount down if it uses one of the affected currencies. opw-4191877 X-original-commit: 8e2fcdc
|
|
|
@lvsz @AntoineVDV this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
|
@lvsz @AntoineVDV 'ci/runbot' failed on this reviewed PR. |
robodoo
pushed a commit
that referenced
this pull request
Dec 20, 2024
Versions -------- - 17.0+ Steps ----- 1. Use COP, HLN or NIO as currency; 2. create a SO or invoice with a non-integer amount total; 3. create a payment link; 4. pay using Mercado Pago. Issue ----- > Error processing payment > Prices in COP currency must be expressed with integer values Cause ----- Our currency defaults follow the ISO 4217 standard for minor units. For three currencies (COP, HLN & NIO), Mercado Pago only accepts integer amounts instead of the standard 2 decimals, resulting in a failed payment transaction. Solution -------- In the payload sent to Mercado Pago, round the amount down if it uses one of the affected currencies. opw-4191877 closes #191214 X-original-commit: 8e2fcdc Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Levi Siuzdak <sile@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 20, 2024
Versions -------- - 17.0+ Steps ----- 1. Use COP, HLN or NIO as currency; 2. create a SO or invoice with a non-integer amount total; 3. create a payment link; 4. pay using Mercado Pago. Issue ----- > Error processing payment > Prices in COP currency must be expressed with integer values Cause ----- Our currency defaults follow the ISO 4217 standard for minor units. For three currencies (COP, HLN & NIO), Mercado Pago only accepts integer amounts instead of the standard 2 decimals, resulting in a failed payment transaction. Solution -------- In the payload sent to Mercado Pago, round the amount down if it uses one of the affected currencies. opw-4191877 closes #191214 X-original-commit: 8e2fcdc Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Levi Siuzdak <sile@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 21, 2024
Versions -------- - 17.0+ Steps ----- 1. Use COP, HLN or NIO as currency; 2. create a SO or invoice with a non-integer amount total; 3. create a payment link; 4. pay using Mercado Pago. Issue ----- > Error processing payment > Prices in COP currency must be expressed with integer values Cause ----- Our currency defaults follow the ISO 4217 standard for minor units. For three currencies (COP, HLN & NIO), Mercado Pago only accepts integer amounts instead of the standard 2 decimals, resulting in a failed payment transaction. Solution -------- In the payload sent to Mercado Pago, round the amount down if it uses one of the affected currencies. opw-4191877 closes #191214 X-original-commit: 8e2fcdc Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Levi Siuzdak <sile@odoo.com>
fw-bot
deleted the
master-17.0-opw-4191877-mercado_pago_currency_rounding-sile-g1CJ-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
Steps
Issue
Cause
Our currency defaults follow the ISO 4217 standard for minor units. For three currencies (COP, HLN & NIO), Mercado Pago only accepts integer amounts instead of the standard 2 decimals, resulting in a failed payment transaction.
Solution
In the payload sent to Mercado Pago, round the amount down if it uses one of the affected currencies.
opw-4191877
Forward-Port-Of: #191084
Forward-Port-Of: #185664