[FW][FIX] sales: computing sales team in invoice #192242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@feg-adhoc @Feyensv ci/runbot failed on this forward-port PR |
|
@feg-adhoc @Feyensv this forward port of #181244 is awaiting action (not merged or closed). |
Feyensv
force-pushed
the
saas-17.4-17.0-h-79599-feg-y0GN-fw
branch
from
b0b7102 to
4ca3d9e
Compare
|
@feg-adhoc @Feyensv this PR was modified / updated and has become a normal PR. It must be merged directly. |
X-original-commit: e8ac922
Feyensv
force-pushed
the
saas-17.4-17.0-h-79599-feg-y0GN-fw
branch
from
4ca3d9e to
c4c8f96
Compare
|
@robodoo r+ |
This was referenced Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
16.0+
Description of the issue/feature this PR addresses:
The issue occurs when selecting a partner in an invoice, the sales team is not correctly computed. The problem arises because the default_team_id is not passed as a parameter to the context when the partner is selected, which works correctly in sales orders but fails in invoices.
Current behavior before PR:
When modifying the partner_id in an invoice, the sales team is not recomputed, leading to incorrect or missing sales team assignment.
Desired behavior after PR is merged:
After this PR is merged, modifying the partner_id on an invoice will correctly recompute the sales team by passing the default_team_id in the context, ensuring consistent behavior between invoices and sales orders.
I will now provide a short video demonstrating the error. This issue is replicable if none of the sales teams have any members assigned.
https://drive.google.com/file/d/15mUpXvdlVpGZXW976PK7EVYH6X4sm2CJ/view?usp=sharing
PR of v16 #180961
Forward-Port-Of: #191674
Forward-Port-Of: #181244