[FW][FIX] base_import: stop importing when everything has been imported #193817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Versions -------- - 17.0+ Steps ----- 1. Create a pricelist with 200 price rules; 2. export pricelist to xlsx; 3. delete original pricelist; 4. import pricelist, setting batch size to 100. Issue ----- Pricelist is imported with 400 price rules. Cause ----- The back-end signals there's nothing left to import by having `nextrow` be falsy[^1]. The front-end ignores this, and continues looping until it's taken as many steps as it initially planned. The upfront `totalSteps` calculation is too high when an imported record has a number of nested relational records that's larger than the batch size. Solution -------- If the ORM returns a falsy `nextrow` value, call `stopImport`. opw-4164056 [^1]: see note on f583682 X-original-commit: ef845ff
lvsz
force-pushed
the
saas-17.4-17.0-opw-4164056-stop_importing_when_everything_has_been_imported-sile-03nZ-fw
branch
from
bd915b7 to
4cd71bf
Compare
|
robodoo r+ |
C3POdoo
requested review from
a team,
Gorash and
xmo-odoo
and removed request for
a team
robodoo
pushed a commit
that referenced
this pull request
Jan 16, 2025
Versions -------- - 17.0+ Steps ----- 1. Create a pricelist with 200 price rules; 2. export pricelist to xlsx; 3. delete original pricelist; 4. import pricelist, setting batch size to 100. Issue ----- Pricelist is imported with 400 price rules. Cause ----- The back-end signals there's nothing left to import by having `nextrow` be falsy[^1]. The front-end ignores this, and continues looping until it's taken as many steps as it initially planned. The upfront `totalSteps` calculation is too high when an imported record has a number of nested relational records that's larger than the batch size. Solution -------- If the ORM returns a falsy `nextrow` value, call `stopImport`. opw-4164056 [^1]: see note on f583682 closes #193817 X-original-commit: ef845ff Signed-off-by: Luca Vitali (luvi) <luvi@odoo.com> Signed-off-by: Levi Siuzdak <sile@odoo.com>
fw-bot
deleted the
saas-17.4-17.0-opw-4164056-stop_importing_when_everything_has_been_imported-sile-03nZ-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
Steps
Test files ready for import:
Issue
Pricelist is imported with 400 price rules.
Cause
The back-end signals there's nothing left to import by having
nextrowbe falsy1. The front-end ignores this, and continues looping until it's taken as many steps as it initially planned.The upfront
totalStepscalculation is too high when an imported record has a number of nested relational records that's larger than the batch size.Solution
If the ORM returns a falsy
nextrowvalue, callstopImport.opw-4164056
Forward-Port-Of: #188092
Footnotes
see note on f583682 ↩