[IMP] runbot: add metadata to log_db #199964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
odoo/netsvc.py
Outdated
Comment on lines
59
to
60
There was a problem hiding this comment.
Missing checking if it returns something
Suggested change
| cr.execute("""SELECT 1 FROM information_schema.columns WHERE table_name='ir_logging' and column_name='metadata'""") | |
| self._support_metadata = True | |
| cr.execute("""SELECT 1 FROM information_schema.columns WHERE table_name='ir_logging' and column_name='metadata'""") | |
| self._support_metadata = bool(cr.rowcount) |
Xavier-Do
force-pushed
the
18.0-netsvc-log-metadata-xdo
branch
5 times, most recently
from
cbb9949 to
d210912
Compare
Xavier-Do
force-pushed
the
18.0-netsvc-log-metadata-xdo
branch
2 times, most recently
from
0303425 to
f05b952
Compare
Xavier-Do
force-pushed
the
18.0-netsvc-log-metadata-xdo
branch
6 times, most recently
from
3a2c325 to
246ca1b
Compare
Williambraecky
approved these changes
Mar 5, 2025
|
@robodoo r+ |
|
@Xavier-Do you may want to rebuild or fix this PR as it has failed CI. |
Xavier-Do
force-pushed
the
18.0-netsvc-log-metadata-xdo
branch
from
246ca1b to
824ac5e
Compare
When handling errors on runbot, it can be difficult to know where a message commes from. It can be problematic to identify automatically the source of an error. This branch give the possibility to add metadata to log_db.
Xavier-Do
force-pushed
the
18.0-netsvc-log-metadata-xdo
branch
from
824ac5e to
f2db31b
Compare
C3POdoo
requested review from
a team,
kmagusiak and
HydrionBurst
and removed request for
a team
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 5, 2025
When handling errors on runbot, it can be difficult to know where a message commes from. It can be problematic to identify automatically the source of an error. This branch give the possibility to add metadata to log_db. closes #199964 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
This was referenced Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling errors on runbot, it can be difficult to know where a message comes from. It can be problematic to identify automatically the source of an error.
This branch give the possibility to add metadata to log_db.
The current only metadata is the canonical tag.
Some other information, like the stack, or the subtest could be added in the future. This is not the case for now to make the review easier.