[FIX] website_sale: Remove original price if prevent sale #202867
Conversation
|
|
livaios
force-pushed
the
17.0-remove-price-prevent-zero-sale-liew
branch
from
80bf8b7 to
b8f48e2
Compare
livaios
force-pushed
the
17.0-remove-price-prevent-zero-sale-liew
branch
from
b8f48e2 to
66d45c0
Compare
livaios
force-pushed
the
17.0-remove-price-prevent-zero-sale-liew
branch
from
66d45c0 to
9b0fd81
Compare
If prevent zero sale is active, prices should be hidden from the page opw-4650460
livaios
force-pushed
the
17.0-remove-price-prevent-zero-sale-liew
branch
from
9b0fd81 to
8e18aaa
Compare
| <div | ||
| t-if="not combination_info['prevent_zero_price_sale']" | ||
| itemprop="offers" | ||
| itemscope="itemscope" | ||
| itemtype="http://schema.org/Offer" | ||
| t-attf-class="product_price mt-2 mb-3 d-inline-block" | ||
| > |
There was a problem hiding this comment.
I think this will also hide rental/subscription prices if the product sales price is 0 👀 (and the rental/sub prices aren't).
I believe we should update the overrides of _get_combination_info in website_sale_subscription and website_sale_renting to update prevent_zero_price_sale (it seems they never considered it at all :D).
There was a problem hiding this comment.
for website_sale_renting they hide the div anyways if its rental so there's no impact there
<xpath expr="//div[@itemprop='offers']" position="attributes">
<attribute name="t-attf-class" separator=" " add="{{'o_hidden' if combination_info.get('is_rental') else ''}}"/>
</xpath>I will add a check in website_sale_subscription so I can either leave website_sale_rental untouched or I can add the same check for consistency there as well what do you think?
There was a problem hiding this comment.
Indeed, there is no issue with rental 👌
If it's not too complex, I'd say that the same check could be added in both modules to keep both logics similar.
|
@robodoo r+ |
If prevent zero sale is active, prices should be hidden from the page opw-4650460 closes #202867 Related: odoo/enterprise#82082 Signed-off-by: Lina Eweis (liew) <liew@odoo.com>
|
Partially reverted in #204524 |
If prevent zero sale is active, prices should be hidden from the page
opw-4650460
See also: https://github.com/odoo/enterprise/pull/82082
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr