9.0 poscertif lpe #20581

kebeclibre · 2017-10-30T15:15:40Z

TASK 29922 (yes, again)

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Main resource document to be found at https://www.economie.gouv.fr/files/files/directions_services/dgfip/controle_fiscal/actualites_reponses/logiciels_de_caisse.pdf This document states that only business operations with partners not being subject to VAT should be inalterable and secure. We adpat the module by differentiating between b2c and b2b journals and apply hashing on the former's moves Protection against account_cancel is not necessary anymore By default, this module considers a sales journal being a b2c, thus activating hashing on its move. Since we can't afford to lose information, when a b2c journal contains hashed moves, its b2c characteristic cannot be changed

qdp-odoo

I found a nice way to tackle everything that was bothering me in account.sale.closure:

remove the m2m on account.move.line
don't use the account.move's write_date (or the account.move's date)
instead, each time you insert a record in that table, save the last (max) l10n_fr_secure_sequence_number found in the system. That field actually gives you chronologically the set of account move you're looking for: you're sure it's unalterable and it allows you to select easily all the move included in the perpetual and periodic totals, without a m2m join (moves having a l10n_fr_secure_sequence_number lesser or equal to that value).

qdp-odoo · 2017-11-30T08:54:31Z

FYI: I checked l10n_fr_pos_cert and it looks OK to me

kebeclibre · 2017-11-30T13:16:06Z

@qdp-odoo
I guess i'm good

odony · 2017-11-30T14:50:25Z

addons/l10n_fr_certification/models/account.py

@@ -6,7 +6,8 @@
 from openerp.tools.translate import _
 from openerp.exceptions import UserError

-ERR_MSG = _("According to the french law, you cannot modify a %s in order for its posted data to be updated or deleted. Field: %s")
+
+ERR_MSG = _("According to the French law, you cannot modify a %s in order for its posted data to be updated or deleted. Unauthorized field: %s.")


The translation here doesn't work. The _() marker will let the system detect a term to include in our translation terms, but it won't actually be able to translate it, because there is no context to do it when the Python file is loaded.
You would need to translate it also at runtime wherever ERR_MSG is used, e.g. _(ERR_MSG).

Additionally, the use of "%s" placeholders here will make translating the sentence awkward. And same thing for the terms that will fill the placeholders, that will be out of context for the translator.

As we only have a couple of variations, it would be both more robust and translator-friendly to just duplicate the whole sentence for every variation. And if the code using the messages is duplicated in many places, you can keep them as "constants", but remember you will need to translate them twice!

Same comments goes for all other occurrences of this pattern, for example BKN_NO_TOUCH (which has even worse placeholders IMO ;-))

@odony interesting, I didn't know the pitfall of translating global variables... but I have to back up @kebeclibre for the %s placeholders: it's a common usage we do all over the code. :-s

odony

A few unsorted comments after a quick scan..

odony · 2017-11-30T15:06:35Z

addons/l10n_fr_sale_closure/models/account_closure.py

+            values['frequency'] = frequency
+            values['company_id'] = company.id
+            values['sequence_number'] = new_sequence_number
+            values['name'] = _('%s Closing - ') % (get_selection_value(self._fields['frequency'], value=frequency),) + values['date_closure_stop'][:10]


Translators will have a hard time guessing what "%s" refers to here ;-)

odony · 2017-11-30T15:46:21Z

addons/l10n_fr_sale_closure/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_l10n_fr_sale_closure_account_sale_closure_user,l10n_fr_sale_closure.account.sale.closure.user,l10n_fr_sale_closure.model_account_sale_closure,,1,0,0,0


You probably want to restrict this to group_user or some appropriate accounting group.
How about multi-company rules?

odony · 2017-11-30T15:53:45Z

addons/l10n_fr_sale_closure/models/account_closure.py

+from openerp.tools.translate import _
+from openerp.exceptions import UserError
+
+WRITE_MSG = _('Sale Closings are not meant to be written or deleted under any circumstances.')


Closing or Closure? I think they can be used interchangeably here, but let's pick just one.

odony · 2017-11-30T15:59:40Z

addons/l10n_fr_sale_closure/models/account_closure.py

+                    aml.id as line_id
+            FROM account_move_line aml
+            JOIN account_journal j ON aml.journal_id = j.id
+            JOIN  (SELECT acc.id FROM account_account acc


Here you can do a plain INNER JOIN without the subselect

odony · 2017-11-30T16:00:51Z

addons/l10n_fr_sale_closure/models/account_closure.py

+        raise UserError(WRITE_MSG)
+
+    @api.model
+    def automated_closure(self, frequency='daily'):


Please make this method private, as it is not meant to be called through RPC.

odony · 2017-11-30T16:08:58Z

addons/l10n_fr_sale_closure/views/account_sale_closure.xml

+            <p class="oe_view_nocontent_nocreate">
+                The closings are created by Odoo
+                </p><p>
+                Sales closings run automatically on a daily, monthly and annual basis. It computes both period and cumulative totals from all the sales entries posted in the system after the previous closing.


closing/closure?

odony · 2017-11-30T16:10:46Z

addons/l10n_fr_certification/data/account_move.xml

+        <field name="code">
+db_uuid = env['ir.config_parameter'].sudo().get_param('database.uuid')
+action = {"type": "ir.actions.act_url",
+          "url": "http://accounts.odoo.com/my/contract/certification-french-accounting/db/" + db_uuid,


Can we make this HTTPS, and use www.odoo.com as the hostname?

odony · 2017-11-30T16:23:20Z

addons/l10n_fr_pos_cert/models/pos.py

+NOT_SAME_DAY_ERROR = _("This session has been opened another day. To comply with the French law, you should close sessions on a daily basis. Please close session %s and open a new one.")
+
+
+def ctx_tz(record, field):


This looks overly complicated on top of fields.Datetime.context_timestamp. Not sure it's necessary?

I am afraid it is (considering the current crappy implementation of the reporting and user friendliness of the output): context_timestamp doesn't format the date to the locale

But it is not crucial to keep that code....

odony · 2017-11-30T16:32:44Z

addons/l10n_fr_sale_closure/models/account_closure.py

+            frequencies are literal (daily means 24 hours and so on)
+        @return {recordset} all the objects created for the given frequency
+        """
+        def get_selection_value(field, value=''):


If you change the value for the selection field from 'annually' to 'annual', you can probably get rid of this ugly function, and replace its calls with simply _(value.capitalize()) (to be tested) ;-)

kebeclibre · 2017-12-01T09:35:45Z

@qdp-odoo
@odony
I am good

fgi-odoo · 2017-12-12T12:29:25Z

@qdp-odoo I suggest to rename modules this way to be improve their visibility (SEO, inside the software) and better meet the competition:
France - VAT Anti-Fraud Certification
France - VAT Anti-Fraud Certification for Point of Sale

Main resource document to be found at https://www.economie.gouv.fr/files/files/directions_services/dgfip/controle_fiscal/actualites_reponses/logiciels_de_caisse.pdf This document states that only business operations with partners not being subject to VAT should be inalterable and secure. We adpat the module by differentiating between b2c and b2b journals and apply hashing on the former's moves Protection against account_cancel is not necessary anymore By default, this module considers a sales journal being a b2c, thus activating hashing on its move. Since we can't afford to lose information, when a b2c journal contains hashed moves, its b2c characteristic cannot be changed [ADD] l10n_fr_pos_cert: module to adapt the POS to the recent French regulation CGI art. 286, I. 3° bis. The module adds following features: - Inalterability: deactivation of all the ways to cancel or modify key data of POS orders, invoices and journal entries - Security: chaining algorithm to verify the inalterability - Access to download the mandatory Certificate of Conformity delivered by Odoo SA (only for Odoo Enterprise users) [ADD] l10n_fr_sale_closing: module to store automatically the total of daily/monthly/annualy sales. (both of the period and cumulative). This fulfills another requirement brought by the recent French regulation CGI art. 286, I. 3° bis related to the storage of data Was PR #20581. Was task 29922

qdp-odoo · 2017-12-13T16:25:25Z

landed in v9 at revision b75927f

Will soon be forward ported to newer versions. Also the link to get the certificate is temporary down, since the internal PR is still under process.

[FIX] l10n_fr_certification: main module Main resource document to be found at https://www.economie.gouv.fr/files/files/directions_services/dgfip/controle_fiscal/actualites_reponses/logiciels_de_caisse.pdf This document states that only business operations with partners not being subject to VAT should be inalterable and secure. We adpat the module by differentiating between b2c and b2b journals and apply hashing on the former's moves Protection against account_cancel is not necessary anymore By default, this module considers a sales journal being a b2c, thus activating hashing on its move. Since we can't afford to lose information, when a b2c journal contains hashed moves, its b2c characteristic cannot be changed [ADD] l10n_fr_pos_cert: module to adapt the POS to the recent French regulation CGI art. 286, I. 3° bis. The module adds following features: - Inalterability: deactivation of all the ways to cancel or modify key data of POS orders, invoices and journal entries - Security: chaining algorithm to verify the inalterability - Access to download the mandatory Certificate of Conformity delivered by Odoo SA (only for Odoo Enterprise users) [ADD] l10n_fr_sale_closing: module to store automatically the total of daily/monthly/annualy sales. (both of the period and cumulative). This fulfills another requirement brought by the recent French regulation CGI art. 286, I. 3° bis related to the storage of data Adaptation of #20581 for version 11.0.

Main resource document to be found at https://www.economie.gouv.fr/files/files/directions_services/dgfip/controle_fiscal/actualites_reponses/logiciels_de_caisse.pdf This document states that only business operations with partners not being subject to VAT should be inalterable and secure. We adpat the module by differentiating between b2c and b2b journals and apply hashing on the former's moves Protection against account_cancel is not necessary anymore By default, this module considers a sales journal being a b2c, thus activating hashing on its move. Since we can't afford to lose information, when a b2c journal contains hashed moves, its b2c characteristic cannot be changed [ADD] l10n_fr_pos_cert: module to adapt the POS to the recent French regulation CGI art. 286, I. 3° bis. The module adds following features: - Inalterability: deactivation of all the ways to cancel or modify key data of POS orders, invoices and journal entries - Security: chaining algorithm to verify the inalterability - Access to download the mandatory Certificate of Conformity delivered by Odoo SA (only for Odoo Enterprise users) [ADD] l10n_fr_sale_closing: module to store automatically the total of daily/monthly/annualy sales. (both of the period and cumulative). This fulfills another requirement brought by the recent French regulation CGI art. 286, I. 3° bis related to the storage of data Was PR odoo#20581. Was task 29922

Main resource document to be found at https://www.economie.gouv.fr/files/files/directions_services/dgfip/controle_fiscal/actualites_reponses/logiciels_de_caisse.pdf This document states that only business operations with partners not being subject to VAT should be inalterable and secure. We adpat the module by differentiating between b2c and b2b journals and apply hashing on the former's moves Protection against account_cancel is not necessary anymore By default, this module considers a sales journal being a b2c, thus activating hashing on its move. Since we can't afford to lose information, when a b2c journal contains hashed moves, its b2c characteristic cannot be changed [ADD] l10n_fr_pos_cert: module to adapt the POS to the recent French regulation CGI art. 286, I. 3° bis. The module adds following features: - Inalterability: deactivation of all the ways to cancel or modify key data of POS orders, invoices and journal entries - Security: chaining algorithm to verify the inalterability - Access to download the mandatory Certificate of Conformity delivered by Odoo SA (only for Odoo Enterprise users) [ADD] l10n_fr_sale_closing: module to store automatically the total of daily/monthly/annualy sales. (both of the period and cumulative). This fulfills another requirement brought by the recent French regulation CGI art. 286, I. 3° bis related to the storage of data Was PR #20581. Was task 29922

kebeclibre added 14 commits August 10, 2017 09:14

After Feedback -- starting

2816068

First pass

15c8938

second pass

f037a1e

[FIX] l10n_fr_certification: a few mistakes corrected

e454a0a

New Implementation getting started

a58fdaa

[FIX] last pass ????

2b90994

[fix] oops forgotten a new file

d06c1df

[FIX] back to hashing all entries

61ca11a

[FIX] check on country

f38395b

Modify sales entries into journal entries

9a9a09d

Last pass hopefully

92b8a60

Skeleton

d0c432a

Skeleton 2.0

9d1951d

kebeclibre requested review from antonylesuisse, odony, fgi-odoo and qdp-odoo October 30, 2017 15:15

kebeclibre added 3 commits October 31, 2017 17:47

Better yet: closure seems done

005667e

wacht en beetje manneke

f6d61f1

wacht en beetje manneke2

a958a88

C3POdoo added the RD research & development, internal work label Nov 2, 2017

kebeclibre added 8 commits November 2, 2017 17:06

Seems good

f78f45a

Add Crons

8210cc1

statring pos

732e511

continue pos

fcae0ee

posconf and bknstmnt good

3380ea4

We really need a hash mixin, but it works nonetheless

2cd7243

[FIX] l10n_pos_cert

13111e5

Add view

d4c5007

qdp-odoo requested changes Nov 30, 2017

View reviewed changes

kebeclibre added 2 commits November 30, 2017 09:48

Getting rid of raising on no country

b45033b

Getting rid of raising on no country

45afad2

kebeclibre added 2 commits November 30, 2017 13:58

Account closure computing on moves secure sequence

d2dccb6

added group account on closure view

834c4fb

odony reviewed Nov 30, 2017

View reviewed changes

kebeclibre added 4 commits November 30, 2017 16:53

Query reform closure

fc84954

Get rid of the constant translations

5266f1a

Replace tuple by dict in string format for inalterbale reports

4708478

Improved security

a66602c

odony requested changes Nov 30, 2017

View reviewed changes

kebeclibre added 5 commits December 1, 2017 09:02

Replace closure by closing

18a1f5a

Replace in voiews closure by closing

36903f2

replace closure by closing3

35458a6

change certif controller route

07af7af

added intercompany rule

fe81084

Added Pot files

0142d32

qdp-odoo closed this Dec 13, 2017

Whenrow mentioned this pull request Jan 19, 2018

[FIX] l10n_fr_certification: adapting to the new specs #22391

Merged

kebeclibre deleted the 9.0-poscertif-lpe branch March 15, 2018 13:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

9.0 poscertif lpe #20581

9.0 poscertif lpe #20581

kebeclibre commented Oct 30, 2017

qdp-odoo left a comment •

edited

Loading

qdp-odoo commented Nov 30, 2017

kebeclibre commented Nov 30, 2017

odony Nov 30, 2017

qdp-odoo Nov 30, 2017

odony left a comment

odony Nov 30, 2017

odony Nov 30, 2017

odony Nov 30, 2017

odony Nov 30, 2017

odony Nov 30, 2017

odony Nov 30, 2017

odony Nov 30, 2017

odony Nov 30, 2017

kebeclibre Dec 1, 2017 •

edited

Loading

odony Nov 30, 2017

kebeclibre commented Dec 1, 2017

fgi-odoo commented Dec 12, 2017 •

edited

Loading

qdp-odoo commented Dec 13, 2017

		@@ -0,0 +1,2 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
		access_l10n_fr_sale_closure_account_sale_closure_user,l10n_fr_sale_closure.account.sale.closure.user,l10n_fr_sale_closure.model_account_sale_closure,,1,0,0,0

		NOT_SAME_DAY_ERROR = _("This session has been opened another day. To comply with the French law, you should close sessions on a daily basis. Please close session %s and open a new one.")


		def ctx_tz(record, field):

9.0 poscertif lpe #20581

9.0 poscertif lpe #20581

Conversation

kebeclibre commented Oct 30, 2017

qdp-odoo left a comment • edited Loading

Choose a reason for hiding this comment

qdp-odoo commented Nov 30, 2017

kebeclibre commented Nov 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

odony left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kebeclibre Dec 1, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kebeclibre commented Dec 1, 2017

fgi-odoo commented Dec 12, 2017 • edited Loading

qdp-odoo commented Dec 13, 2017

qdp-odoo left a comment •

edited

Loading

kebeclibre Dec 1, 2017 •

edited

Loading

fgi-odoo commented Dec 12, 2017 •

edited

Loading