Skip to content

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented May 5, 2025

After this commit:

  • Allowed all presets to be set as default.
  • Added a shortcut to edit presets from settings.
  • Renamed Others to Available for clarity.
  • Users can select a default preset only from available presets.
  • Enabled users to change preset identification, even if set as default.
  • Improved field names for better usability.
  • Restricted deletion of master and in-use presets.

Task: 4523232
Related PR: #202640

Forward-Port-Of: #207977
Forward-Port-Of: #196800

@robodoo
Copy link
Contributor

robodoo commented May 5, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented May 5, 2025

@djip-odoo @caburj cherrypicking of pull request #196800 failed.

stdout:

Auto-merging addons/point_of_sale/i18n/point_of_sale.pot
Auto-merging addons/point_of_sale/models/pos_config.py
Auto-merging addons/point_of_sale/static/src/app/screens/ticket_screen/ticket_screen.js
Auto-merging addons/point_of_sale/static/src/app/services/pos_store.js
Auto-merging addons/point_of_sale/views/res_config_settings_views.xml
CONFLICT (content): Merge conflict in addons/point_of_sale/views/res_config_settings_views.xml

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels May 5, 2025
@C3POdoo C3POdoo added the RD research & development, internal work label May 5, 2025
After this commit:
- Allow all presets to set as default.
- Add shortcut to edit presets from settings.
- Renamed the "Others" field label to "Available" in preset settings. 
- Now it allow users to select a "default" preset from the available selections.
- Remove restriction for identification presets.
- Clarify field names for better usability in preset form view.
- Restricted to delete master preset data.
- Restricted user to delete used preset in anyone config.

Task: 4523232
Related PR: odoo#202640

X-original-commit: ac78f14
@djip-odoo djip-odoo force-pushed the master-saas-18.1-pos-imp-fix-preset-config-better-ux-djip-432749-fw branch from 17a100f to eb0d5ad Compare May 5, 2025 13:12
@C3POdoo C3POdoo requested review from a team and adgu-odoo and removed request for a team May 5, 2025 13:15
@djip-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request May 6, 2025
After this commit:
- Allow all presets to set as default.
- Add shortcut to edit presets from settings.
- Renamed the "Others" field label to "Available" in preset settings. 
- Now it allow users to select a "default" preset from the available selections.
- Remove restriction for identification presets.
- Clarify field names for better usability in preset form view.
- Restricted to delete master preset data.
- Restricted user to delete used preset in anyone config.

Task: 4523232
Related PR: #202640

closes #208432

X-original-commit: ac78f14
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Dhruv Jitendrakumar Patel (djip) <djip@odoo.com>
@robodoo robodoo added the 18.4 label May 6, 2025
@robodoo robodoo closed this May 6, 2025
@fw-bot fw-bot deleted the master-saas-18.1-pos-imp-fix-preset-config-better-ux-djip-432749-fw branch May 13, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18.4 conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants