Skip to content

Conversation

agr-odoo
Copy link
Contributor

@agr-odoo agr-odoo commented May 3, 2021

Have in a purchase order a first row with unit price 0
Export the PO adding unit price in the list of fields to export
The unit price is not reported

This occur because the first line of the order lines is meld with the
purchase order line but in the process the 0.0 values is discarded

opw-2510917

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@agr-odoo
Copy link
Contributor Author

agr-odoo commented May 3, 2021

@nle-odoo

@robodoo
Copy link
Contributor

robodoo commented May 3, 2021

Pull request status dashboard

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label May 3, 2021
Copy link
Contributor

@nle-odoo nle-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sens with the change that added the bool case: 68f9f99

but wouldn't this happen also with integer? in this case we might just replace bool by (float, int) to handles the three classes

robodoo delegate+

Have in a purchase order a first row with unit price 0
Export the PO adding unit price in the list of fields to export
The unit price is not reported

This occur because the first line of the order lines is meld with the
purchase order line but in the process the 0.0 values is discarded

opw-2510917
@agr-odoo agr-odoo force-pushed the 12.0-opw-2510917-fix-agr branch from 07dd121 to 1da6782 Compare May 4, 2021 13:53
@agr-odoo
Copy link
Contributor Author

agr-odoo commented May 4, 2021

but wouldn't this happen also with integer? in this case we might just replace bool by (float, int) to handles the three classes

Indeed, that's a great addition, thanks!

@agr-odoo
Copy link
Contributor Author

agr-odoo commented May 4, 2021

robodoo r+

robodoo pushed a commit that referenced this pull request May 4, 2021
Have in a purchase order a first row with unit price 0
Export the PO adding unit price in the list of fields to export
The unit price is not reported

This occur because the first line of the order lines is meld with the
purchase order line but in the process the 0.0 values is discarded

opw-2510917

closes #70274

Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
@robodoo robodoo closed this May 4, 2021
@robodoo robodoo temporarily deployed to merge May 4, 2021 15:48 Inactive
@nle-odoo nle-odoo deleted the 12.0-opw-2510917-fix-agr branch May 5, 2021 14:23
kzhekov pushed a commit to odoo-dev/odoo that referenced this pull request Jun 28, 2021
Have in a purchase order a first row with unit price 0
Export the PO adding unit price in the list of fields to export
The unit price is not reported

This occur because the first line of the order lines is meld with the
purchase order line but in the process the 0.0 values is discarded

opw-2510917

closes odoo#70274

Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants