[IMP] estate: Add validation conditions

Author: nguyenntph

estate/models/estate_property.py

@@ -1,5 +1,6 @@
 from odoo import api, fields, models
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_is_zero, float_compare
 
 
 class EstateProperty(models.Model):
@@ -58,6 +59,15 @@ class EstateProperty(models.Model):
     tag_ids = fields.Many2many('estate.property.tag', string='Tags')
     offer_ids = fields.One2many('estate.property.offer', 'property_id', string='Offers')
 
+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price > 0)',
+        'The expected price of a property should be strictly positive.',
+    )
+    _check_selling_price = models.Constraint(
+        'CHECK(selling_price >= 0)',
+        'The selling price of a property should be positive.',
+    )
+
     @api.depends('living_area', 'garden_area')
     def _compute_total_area(self):
         for record in self:
@@ -79,6 +89,16 @@ def _onchange_garden(self):
             self.garden_area = None
             self.garden_orientation = None
 
+    @api.constrains('selling_price', 'expected_price')
+    def _check_selling_price(self):
+        for record in self:
+            if (
+                not float_is_zero(record.selling_price, 2)
+                and float_compare(record.selling_price, record.expected_price * 0.90, 2) < 0
+            ):
+                raise ValidationError("Selling price cannot be lower than 90% of expected price")
+
+
     def action_mark_as_sold(self):
         for record in self:
             if record.state == 'cancelled':

estate/models/estate_property_offer.py

@@ -19,6 +19,11 @@ class EstatePropertyOffer(models.Model):
     validity = fields.Integer(default=7)
     date_deadline = fields.Date(compute='_compute_deadline', inverse="_inverse_deadline")
 
+    _check_price = models.Constraint(
+        'CHECK(price > 0)',
+        'The price of an offer should be strictly positive.',
+    )
+
     @api.depends('create_date', 'validity')
     def _compute_deadline(self):
         for record in self:

estate/models/estate_property_tag.py

@@ -6,3 +6,8 @@ class EstatePropertyTag(models.Model):
     _description = 'All property tags'
 
     name = fields.Char(required=True)
+
+    _check_unique_name = models.Constraint(
+        'unique (name)',
+        'The name of a tag should be unique.',
+    )