-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/storage validation #162
Conversation
This pull request introduces 1 alert when merging abda094 into a70c542 - view on LGTM.com new alerts:
|
- Avoid to import same package with 'import' and 'import from' - Make code confirm with LGTM recommendation
@c-moeller please have a look at the documentation and let me know if you understand how the validation was conducted from what I wrote so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakob-wo Thank you for the validation! It reads good and understandable. I've just made some small remarks.
Could you give a final statement about the storage model below the figure? Does it calculate losses in an appropriate way for energy system analysis? And why are the measurement data fluctuating that much? Measuring inaccuracy?
And one final question: You did the validation for a quite high storage level. Maybe you can add a line, why this is sufficient. Or should we contrast a validation with lower storage levels?
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
@c-moeller, thank you for the review! I added the missing text in the results section and considered your suggestions in the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
I've just made some small change in the table. Sorry, maybe it was not clear what I meant.
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
Co-authored-by: Caroline Möller <caroline.moeller@rl-institut.de>
@c-moeller: Great! I am going to merge it then. Thank you. |
This PR adds a validation of the stratified thermal storage model to the documentation.
The code behind it (creates the figure) is added to the example section.