Fixed fabtests issues with the change of cq/eq_read return value #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shantonu Hossain <shantonu.hossain@intel.com>
| if (ret == -FI_EAVAIL) { | ||
| if (ret == -FI_EAGAIN) | ||
| continue; | ||
| else if (ret == -FI_EAVAIL) { |
There was a problem hiding this comment.
To follow the coding guidelines, if either portion of an if statement uses braces, both portions should. I.e. rewrite as
if (ret == -FI_EAGAIN) {
continue;
} else ...
Problem repeated throughout patch.
There was a problem hiding this comment.
Sorry about that! Fixing it.
Signed-off-by: Shantonu Hossain <shantonu.hossain@intel.com>
shantonu
force-pushed
the
fabtests-devel
branch
from
f2c3406
to
58d2b86
Compare
Signed-off-by: Shantonu Hossain <shantonu.hossain@intel.com>
shantonu
force-pushed
the
fabtests-devel
branch
from
58d2b86
to
f255f0d
Compare
|
Pushed all the suggested changes! |
| @@ -379,7 +383,9 @@ static int shutdown_events(void) | |||
|
|
|||
| while (disconnects_left && !ret) { | |||
| ret = fi_eq_sread(eq, &event, &entry, sizeof entry, -1, 0); | |||
| if (ret < 0) { | |||
| if (ret == -FI_EAGAIN) | |||
| continue; | |||
There was a problem hiding this comment.
This will break out of the while loop
There was a problem hiding this comment.
Actually in both loops above, we're blocking forever until we read an event. So even seeing EAGAIN would be unexpected. Both changes above should probably be reverted.
Signed-off-by: Shantonu Hossain <shantonu.hossain@intel.com>
shantonu
force-pushed
the
fabtests-devel
branch
from
c02d856
to
a43a934
Compare
shefty
added a commit
that referenced
this pull request
Mar 26, 2015
Fixed fabtests issues with the change of cq/eq_read return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192 @patrickmacarthur @bturrubiates @jithinjosepkl, can you please review?
Signed-off-by: Shantonu Hossain shantonu.hossain@intel.com