fix: move database migrations to hooks.server vs layout server

[kmendell]

Summary by Sourcery

Move database initialization and migration logic from layout server to server hooks to ensure consistent and early database setup

Bug Fixes:

• Ensure database is initialized and migrations are run before application starts, preventing potential race conditions or initialization errors

Enhancements:

• Centralize database initialization logic in a single async initialization function
• Add error handling for database initialization process

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request moves the database initialization and migration logic from the layout server to the server hooks. This ensures that the database is initialized and migrated only once when the server starts, rather than on every request to the layout. An initialization function was created to encapsulate database and sync service initialization.

Sequence diagram for database initialization and migration in server hooks

sequenceDiagram
    participant ServerHooks
    participant initDatabase
    participant runMigrations
    participant RegistrySyncService

    ServerHooks->>initDatabase: initialize()
    activate initDatabase
    initDatabase->>initDatabase: Initialize database connection
    initDatabase-->>ServerHooks: Complete
    deactivate initDatabase

    ServerHooks->>runMigrations: await runMigrations()
    activate runMigrations
    runMigrations->>runMigrations: Apply pending database migrations
    runMigrations-->>ServerHooks: Complete
    deactivate runMigrations

    ServerHooks->>RegistrySyncService: getInstance()
    activate RegistrySyncService
    RegistrySyncService->>RegistrySyncService: Start sync service
    RegistrySyncService-->>ServerHooks: Complete
    deactivate RegistrySyncService

Loading

File-Level Changes

Change	Details	Files
Moved database initialization and migrations from the layout server to the server hooks.	Removed database initialization and migration logic from the layout server. Added database initialization and migration logic to the server hooks. Created an initialization function to encapsulate database and sync service initialization. Invoked the initialization function when the server starts.	src/hooks.server.ts src/routes/+layout.server.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @kmendell - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a health check endpoint to verify successful initialization.
• The initialize function could be extracted to a separate module for better organization.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Reconsider error handling strategy during initialization.

Currently, errors during initialization are logged but not propagated, which might allow the server to continue operating in a potentially inconsistent state. Depending on the application's requirements, it might be better to handle such failures more robustly (for example, by exiting the process or triggering a fallback) to prevent unpredictable behavior.

Suggested change

	} catch (error) {
	logger.error('Failed to initialize application:', error);
	}
	} catch (error) {
	logger.error('Failed to initialize application:', error);
	process.exit(1);
	}