Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SCons build system with WAF #15

Closed
caitp opened this issue Feb 10, 2014 · 6 comments
Closed

Replace SCons build system with WAF #15

caitp opened this issue Feb 10, 2014 · 6 comments

Comments

@caitp
Copy link

caitp commented Feb 10, 2014

WAF was originally forked from SCons, so it should be relatively simple to port, but has some nice advantages:

A) can be simply checked into the tree, omitting the requirement for a global install (this could simplify configuring CI builds, which would be a major benefit for any open source project)

B) was originally forked from SCons for performance reasons, and is intended to provide a much quicker build time.

I might have a go at porting this over today, in order to simplify the build and help enable a CI process for the repository.

@reduz
Copy link
Member

reduz commented Feb 10, 2014

I didn't know about WAF, this is good to know!

However, if you look at it, you'll realize that the build system in Godot is extremely complex, and even uses scons in ways it's not meant to be used (SCons complains but does the job), so it's probably a much more difficult task that it might seem at first.

@caitp
Copy link
Author

caitp commented Feb 10, 2014

Yeah probably, build system migrations always are :p I think it's worth a shot though

@TiZ-HugLife
Copy link
Contributor

I personally love waf, and use it for all my projects, so I'm all for this.

@caitp
Copy link
Author

caitp commented Feb 11, 2014

I'd actually think that gyp would be nicer, because I'm using it for a lot of private projects these days and it's nice to not have to set up any integration with another build system.

But anyways, I'm working on this a bit today, might be able to complete it by the end of the week, at which point I'd like to start working on implementing some CI and improving the test suite (since, from the looks of things, the test suite is pretty much crash testing at best). If anyone wants to be CC'd to review the pull request, you should let me know here

@akien-mga
Copy link
Member

Was there any work done on this feature in the end? I don't see any relevant commit in @caitp's fork.

@akien-mga
Copy link
Member

There was no recent activity nor much community interest in this issue, so I'll close it as old.

AndreaCatania referenced this issue in AndreaCatania/godot Jul 10, 2020
Implemented triangulation
lawnjelly added a commit to lawnjelly/godot that referenced this issue Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants