-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a Github Action for Cypress #248
Conversation
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're not using latest (v3) here? Looks like the main diff is updating to node 16 and various dep updates - if cypress runs on it would be nice to start at latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had tried v3 earlier, but it didn't execute. Quite possible I had made some other error (I also tried setting NodeJS with a actions/setup-node@v3
or some such). I'll try v3 here, and v4 for cypress.
- name: Checkout | ||
uses: actions/checkout@v2 | ||
- name: Run Cypress tests | ||
uses: cypress-io/github-action@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar question here with using @v4 for cypress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I updated this value as well. The workflow executes successfully.
- name: Run Cypress tests | ||
uses: cypress-io/github-action@v2 | ||
with: | ||
start: yarn run start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should be able to just use yarn start
(no run)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
Going forward, we'll run our Cypress acceptance tests on PRs, at time of creation as well as for any subsequent changes to that branch. Adding a Github Action for Cypress Fixing syntax error in YAML Fixing syntax error in YAML Revising workflow Fixing syntax Adding external registry Change from yarn to npm Changing registry Adding option Modifying workflow Basic workflow Start local server Added simple server Revising workflow Node version checkout and node removing node Revised paths in tests
d2234cf
to
4deb508
Compare
No description provided.