Cleanup leaderboard code

Author: gc

src/mahoji/commands/leaderboard.ts

@@ -28,15 +28,6 @@ import { getUsername, getUsernameSync } from '@/lib/util.js';
 
 const LB_PAGE_SIZE = 10;
 
-function lbMsg(str: string, ironmanOnly?: boolean) {
-	return {
-		content: `Showing you the ${str} leaderboard, click the buttons to change pages.${
-			ironmanOnly ? ' Showing only ironmen.' : ''
-		}`,
-		ephemeral: true
-	};
-}
-
 async function bulkGetUsernames(userIDs: string[]) {
 	await Promise.all(uniqueArr(userIDs).map(id => getUsername(id)));
 }
@@ -94,7 +85,13 @@ async function doMenuWrapper({
 					`${getPos(c, i)}**${user.full_name ?? (await getUsername(user.id))}:** ${formatter ? formatter(user.score) : user.score.toLocaleString()}`
 			);
 			const pageText = (await Promise.all(unwaited)).join('\n');
-			return { embeds: [new EmbedBuilder().setTitle(title).setDescription(pageText)] };
+			return {
+				embeds: [
+					new EmbedBuilder()
+						.setTitle(`${title}${ironmanOnly ? ' (Ironmen Only)' : ''}`)
+						.setDescription(pageText)
+				]
+			};
 		};
 		pages.push(makePage);
 	}
@@ -103,19 +100,7 @@ async function doMenuWrapper({
 	}
 
 	return interaction.makePaginatedMessage({
-		pages: pages.map((p, i) => {
-			if (isFunction(p)) {
-				return p;
-			}
-
-			return {
-				embeds: [
-					new EmbedBuilder()
-						.setTitle(`${lbMsg(title, ironmanOnly).content} (Page ${i + 1}/${pages.length})`)
-						.setDescription(p)
-				]
-			};
-		})
+		pages
 	});
 }