Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CONTRIBUTING and PULL_REQUEST_TEMPLATE files #139

Closed
osteele opened this issue Apr 21, 2018 · 0 comments
Closed

Create CONTRIBUTING and PULL_REQUEST_TEMPLATE files #139

osteele opened this issue Apr 21, 2018 · 0 comments
Labels
good first issue internal Affects abe-web development and developers
Milestone
Release 1.6 — Ret...

Comments

@osteele
Copy link
Contributor

osteele commented Apr 21, 2018

To make it easier to contribute, and maintain the code quality, create one or both of .github/CONTRIBUTING and .github/PULL_REQUEST_TEMPLATE.

These should at least specify that yarn test and yarn lint must pass.
osteele added a commit that referenced this issue Apr 22, 2018
@osteele
Add a PR template
358b5fe 
Partially addresses #139
osteele added a commit that referenced this issue Apr 22, 2018
@osteele
Add a PR template
9af161f 
Partially addresses #139
osteele added a commit that referenced this issue Apr 22, 2018
@osteele
Add a PR template
f43418f 
Partially addresses #139
@osteele osteele added the internal Affects abe-web development and developers label Apr 23, 2018
@osteele osteele added this to the Release 1.5 — community disclosure milestone Apr 24, 2018
@osteele osteele modified the milestones: Release 1.5 — Community Friday, Release 1.6 — return to school May 15, 2018
osteele added a commit that referenced this issue May 16, 2018
@osteele
Factor setup information from README into new CONTRIBUTING guide
8b25979 
Completes #139.
@osteele osteele closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue internal Affects abe-web development and developers
Projects
None yet
Milestone
Release 1.6 — Return to School
Development

No branches or pull requests
1 participant
@osteele