New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily eslint #230

Merged

osteele merged 1 commit into dev from osteele/eslint

May 12, 2018

Contributor

osteele commented May 11, 2018

Description

Incremental eslint-airbnb compliance.

Required

Changes must conform to these requirements:

yarn test passes. All new and existing tests pass.
yarn lint passes. All new code follows the code style of this project.

Aspirational

We don't yet require these, but they are nice to have:

New code is covered by new or existing tests.
Changed code is covered by new or existing tests.


          Daily eslint

8fe3ea2

osteele requested a review from kylecombes

May 11, 2018 11:33

coveralls commented May 11, 2018

Pull Request Test Coverage Report for Build 304

3 of 21 (14.29%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 21.972%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/pages/add-edit/save-cancel-buttons.jsx	1	3	33.33%
src/pages/add-edit/add-edit-page.jsx	0	3	0.0%
src/components/picker-popup.jsx	2	15	13.33%

Totals
Change from base Build 301:	0.1%
Covered Lines:	93
Relevant Lines:	448

💛 - Coveralls

osteele merged commit 740d741 into dev

osteele deleted the osteele/eslint branch

May 12, 2018 16:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment