-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ngff tools table #139
Ngff tools table #139
Conversation
Automated Review URLs |
I think we are approaching the point (see also #140) where we need to decide if everything is going into the spec page or if we're going to host one or more additional sites. If so, then we should gather thoughts (like https://ome.github.io/ngff)
If we end up using markdown, then I'd suggest a data file (like in yaml)
|
This also echoes some of the questions I raised in #138 (review) re hosting and maintaining different but complementary types of documentation. |
Could we also add itkwidgets? The current values are:
Also add a column for v0.4 metadata? |
I had an issue while testing the itkwidgets in a conda env on Mac M1 See InsightSoftwareConsortium/itkwidgets#548 |
For webKnossos:
We also maintain the |
567dbbc
to
a755889
Compare
a755889
to
36f376d
Compare
Thanks @normanrz - I've been playing with webknosses for the first time, importing an OME-NGFF image from https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0062A/6001240.zarr, which is a 2-channel image with labels. But I can only see the first channel imported into webknosses. Is there a way to import multiple layers from the one source? |
Hey @will-moore, so far we only support single-channel images, but support for multi-channel is coming next month. Labels should work. Perhaps you're running into a bug here. I'll investigate. |
Thanks for the report. I followed up there. Here is what I get on my Mac M1: OME-NGFF-Bra.-.JupyterLab.webmitkwidgets 1.X is built around OME-NGFF. But, maybe we should clarify:
|
@normanrz Thanks. Here's another I tried - I wanted to see if the The response in
The
|
Thanks for testing these different samples! |
Ah, yes - that was just me manually editing the |
9da055a
to
ec89a03
Compare
ngff-tools.md
Outdated
<td>n</td> | ||
<td>?</td> | ||
<td>y (scale)</td> | ||
<td>y (scale)</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line, which says webknossos opens ?
should say something like
errors for the first image (with scale and transform)
opens for the second image (with only scale)
This invites a split of this line into the first image (scale & transform) and the second image (scale).
We also need a better expression for the n
which at present means "does not support the feature which the particular image is trying to highlight, it opens the image but ignores the feature".
We should also probably consider expanding https://idr.github.io/ome-ngff-samples/ and add the viewers icons to that table too |
@jburel What do you mean "add the viewers icons to that table"? There are icons (links) for vizarr and itk-viewer where we have useful links. But we don't have links for the other viewers. So there's no meaning to icons for them either? |
@pwalczysko A support table like at https://caniuse.com/dialog is quite nice & contains extra info as we were discussing - mousing over each table cell gives a popup with more info, and mousing over the foot-notes highlights the relevant table cells (and vice versa). |
What I mean is that if for example it is supported in Mobie, we could add the mobie icon and link to either the guide or an example script. |
04af053
to
f269620
Compare
f269620
to
36de81c
Compare
We have done a bunch of testing and it's time to update the table but...
So this really needs to be somewhere it can be deployed.
This decision is really a blocker at the moment, so to make progress I might just create a new repo or pick one of those above in the absence of any other decision... |
Thanks to everyone for all the contributions here! It was exciting to catch up on all the back and forth. Just a heads up that we decided today to migrate this work to its own repo so that we have more control over the rendering of the various cells. Hopefully that will also attract others to participate as well! 🙌🏽 |
@joshmoore Moved to |
❤️ Hugely readable. |
nice |
So the table at https://will-moore.github.io/ome-ngff-tools/ is getting mostly complete now, just need to look at neuroglancer... @jburel @joshmoore next steps? Does the table
|
closing this now... but feel free to continue the discussion here... |
👍 |
Started to look again at #71
View page at https://github.com/will-moore/ngff/blob/ngff_tools_table/ngff-tools.md
Aims of this table/documentation:
Created a top-level
ngff-tools.md
page.Tried tables (duplicates) in markdown format or html.
The current table is for "viewers" but I think we could possibly list other tools for producing OME-NGFF too (bioformats2raw, ome-ngff, omero-cli-zarr etc).
First questions:
cc @manzt @constantinpape @joshmoore @sbesson