#2 React hooks #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks grate! I was not sure if I should switch to RTL lol. so, i left it be with a nice little comment about implementation detail testing. :) Tests look good |
ghost
approved these changes
Oct 4, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This looks goods, should we switch to test() instead of describe and it?
Author
|
Regarding "it" or "test", it does not really matter for me. I usually use "it" so that you can write it as a sentence, it('renders correctly'), it('renders button if state is blablalba'). Describe is needed (afaik) to wrap your tests. If it is not, it is still good to wrap your tests with a description of what component you are testing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored to a functional component and updated some dependencies to get the tests to work. Enzyme does not support hooks atm.