Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll movement doesn't work #519

Closed
lourenci opened this issue Jul 31, 2019 · 5 comments
Closed

Scroll movement doesn't work #519

lourenci opened this issue Jul 31, 2019 · 5 comments

Comments

@lourenci
Copy link

@lourenci lourenci commented Jul 31, 2019

I downloaded the early app for Mac and some key bindings for movements seem not working.

CTRL + d: Instead of half screen down, oni is moving one line down.
CTRL + u: Instead of half screen up, oni is moving one line up.
CTRL + f: Instead of screen down, oni does nothing at all.
CTRL + b: It works.

@pkariz
Copy link

@pkariz pkariz commented Aug 5, 2019

CTRL + d and CTRL + u don't always move by 1, but sometimes by 8 and 18 also. The reproduction step for 8 lines movement when using i3:

  1. make onivim2 fullscreen
  2. undo fullscreen

Loading

@bryphe
Copy link
Member

@bryphe bryphe commented Aug 5, 2019

Thanks for the details, @pkariz !

I believe there is something going wrong with the synchronization between Onivim 2 <-> libvim. We push information here to libvim about window metrics:

let synchronizeWindowMetrics =

And it's either that we aren't sending / updating the right values... or there is also the possibility that there could be something happening on the libvim side that is limiting the viewable space.

Loading

@bryphe
Copy link
Member

@bryphe bryphe commented Aug 7, 2019

The <c-d>/<c-u> issues should now be addressed by this fix in libvim (now in master): onivim/libvim#158

There was an additional issue / bug blocking the <c-f> key - we were sending it to Vim as <c-k>. This was a revery bug: revery-ui/revery#533

Loading

@bryphe
Copy link
Member

@bryphe bryphe commented Aug 7, 2019

Will verify and close once these fixes have made it to master 👍

Loading

@bryphe bryphe closed this in #618 Aug 7, 2019
bryphe added a commit that referenced this issue Aug 7, 2019
* Pin revery to pick up Key_F fix

* Update lockfiles
@bryphe
Copy link
Member

@bryphe bryphe commented Aug 7, 2019

Should now be addressed by the fixes described in #618 - let me know if you are still seeing issues, though!

Loading

benox3 added a commit to benox3/oni2 that referenced this issue Aug 27, 2019
* Pin revery to pick up Key_F fix

* Update lockfiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants