Scroll movement doesn't work

[lourenci]

I downloaded the early app for Mac and some key bindings for movements seem not working.

CTRL + d: Instead of half screen down, oni is moving one line down.
CTRL + u: Instead of half screen up, oni is moving one line up.
CTRL + f: Instead of screen down, oni does nothing at all.
CTRL + b: It works.

[pkariz]

CTRL + d and CTRL + u don't always move by 1, but sometimes by 8 and 18 also. The reproduction step for 8 lines movement when using i3:

1. make onivim2 fullscreen
2. undo fullscreen

[bryphe]

Thanks for the details, @pkariz !

I believe there is something going wrong with the synchronization between Onivim 2 <-> libvim. We push information here to libvim about window metrics:

oni2/src/editor/Store/VimStoreConnector.re

Line 425 in 71e6e3b

let synchronizeWindowMetrics =

And it's either that we aren't sending / updating the right values... or there is also the possibility that there could be something happening on the libvim side that is limiting the viewable space.

[bryphe]

The <c-d>/<c-u> issues should now be addressed by this fix in libvim (now in master): onivim/libvim#158

There was an additional issue / bug blocking the <c-f> key - we were sending it to Vim as <c-k>. This was a revery bug: revery-ui/revery#533

[bryphe]

Will verify and close once these fixes have made it to master 👍

[bryphe]

Should now be addressed by the fixes described in #618 - let me know if you are still seeing issues, though!