Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update due to feedback in #9 #11

Merged
merged 1 commit into from Jul 7, 2019

Conversation

Projects
None yet
2 participants
@VincentTam
Copy link
Collaborator

commented Jul 7, 2019

I hope I get you correctly in #9 (comment). Here's some explanations to the words that I'm using.

I've started this PR instead of directly pushing it into the repo to allow discussion before any actual commit against the master branch. Besides, I treat each Git branch as an independent feature. Even though it's good to branch from current stable version to include recent updates and avoid bugs, I didn't include the recently merged PR to avoid obfuscating the commit history of the branch VincentTam:smapich to be merged.

@VincentTam VincentTam self-assigned this Jul 7, 2019

@onweru

This comment has been minimized.

Copy link
Owner

commented Jul 7, 2019

I hope I get you correctly in #9 (comment). Here's some explanations to the words that I'm using.

I've started this PR instead of directly pushing it into the repo to allow discussion before any actual commit against the master branch. Besides, I treat each Git branch as an independent feature. Even though it's good to branch from current stable version to include recent updates and avoid bugs, I didn't include the recently merged PR to avoid obfuscating the commit history of the branch VincentTam:smapich to be merged.

@VincentTam, well said, I get your approach; discretion is a good thing to have. My request was discretionary, just ensuring that we didn't overlook something. Seeing that you're a thorough person, I would be ok with the README as is, if you think the staticman part is adequately documented.

@onweru onweru merged commit 15982b8 into onweru:master Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.