Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: upgrade to go1.19 #2211

Closed
bassosimone opened this issue Aug 11, 2022 · 0 comments · Fixed by ooni/probe-cli#1017
Closed

cli: upgrade to go1.19 #2211

bassosimone opened this issue Aug 11, 2022 · 0 comments · Fixed by ooni/probe-cli#1017
Assignees
@bassosimone
Labels
chore routine tasks that must be done, but require little active brain power ooni/probe-cli ooni/probe-engine priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Aug 11, 2022 •
edited
Loading

This issue is about migrating ooni/probe-cli's master branch to use go1.19.

This task is currently blocked by #2222: we cannot use go1.19 for building ooniprobe until we figure out how to fix the Psiphon build. In the interim, it's possible to build with go1.19, but psiphon won't work.
@bassosimone bassosimone self-assigned this Aug 11, 2022
@bassosimone bassosimone added user feedback requests that have been added to the backlog as a direct result of user feedback or testing priority/high chore routine tasks that must be done, but require little active brain power ooni/probe-cli ooni/probe-engine and removed triage labels Aug 11, 2022
@bassosimone bassosimone mentioned this issue Aug 18, 2022
Merged
bassosimone added a commit to ooni/oohttp that referenced this issue Aug 18, 2022
@bassosimone
fix: make sure we don't assume *net.Conn anywhere
8700446 
This work is part of ooni/probe#2211.
bassosimone added a commit to ooni/oohttp that referenced this issue Aug 18, 2022
@bassosimone
fix: tls.Client => TLSClientFactory
548f8fa 
Part of ooni/probe#2211.
bassosimone added a commit to ooni/oohttp that referenced this issue Aug 18, 2022
@bassosimone
chore: update submodules
a56c194 
Unfortunately ja3er.com is down, so the examples now are much
less useful than they were before :-(.

Part of ooni/probe#2211
@bassosimone bassosimone mentioned this issue Aug 18, 2022
Merged
bassosimone added a commit to ooni/oocrypto that referenced this issue Aug 18, 2022
@bassosimone
Merge branch 'golang-crypto-upstream' into merged-main
85c8ec1 
This merge has been interesting. It took quite some time and I
realized that I could further simplify the codebase by removing
all the assembly implementations we don't need.

Part of ooni/probe#2211.
@bassosimone bassosimone mentioned this issue Aug 18, 2022
Merged
bassosimone added a commit to ooni/oocrypto that referenced this issue Aug 18, 2022
@bassosimone
Merge pull request #6 from ooni/merged-main
72b2086 
Merged go1.19 src/crypto into ooni/oocrypto

See ooni/probe#2211
bassosimone added a commit to ooni/oocrypto that referenced this issue Aug 19, 2022
@bassosimone
fix: ensure the conn we export implements NetConn
b56ea5a 
I am not sure there's any issue in _building_ against the latest
stable release of oocrypto (and I shall soon see), but in any case
it feels more correct to include `NetConn()` into the model.

Part of ooni/probe#2211
@bassosimone bassosimone mentioned this issue Aug 19, 2022
Merged
bassosimone added a commit to ooni/oocrypto that referenced this issue Aug 19, 2022
@bassosimone
Merge pull request #8 from ooni/issue/2211
0e8e89c 
fix: ensure the conn we export implements NetConn

Part of ooni/probe#2211
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 19, 2022
@bassosimone
chore: upgrade deps and attempt to enable using go1.19
1c9593d 
* upgrade to our go.mod enabled of psiphon-tunnel-core such that
we're now using v2.0.24 of the tunnel-core;

* upgrade to the latest lucas-clemente/quic-go release;

* upgrade to the latest ooni/oohttp release (which is based on go1.19
but the diff seems good enough to continue using go1.18.x as well);

* upgrade to the latest ooni/oocrypto release (for which we can make the
same remarks regarding using go1.18.x);

* deal with changes in lucas-clemente/quic-go API as well as changes
in what a go1.19 *tls.Conn compatible type should look like.

Unfortunately, we cannot switch to go1.19 because psiphon forks quic-go
and their fork's still not building using such a version of go.

Part of ooni/probe#2211.
@bassosimone bassosimone mentioned this issue Aug 19, 2022
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 19, 2022
@bassosimone
chore: upgrade deps and attempt to enable using go1.19 (#869)
9ffa124 
* upgrade to our go.mod enabled of psiphon-tunnel-core such that
we're now using v2.0.24 of the tunnel-core;

* upgrade to the latest lucas-clemente/quic-go release;

* upgrade to the latest ooni/oohttp release (which is based on go1.19
but the diff seems good enough to continue using go1.18.x as well);

* upgrade to the latest ooni/oocrypto release (for which we can make the
same remarks regarding using go1.18.x);

* deal with changes in lucas-clemente/quic-go API as well as changes
in what a go1.19 *tls.Conn compatible type should look like.

Unfortunately, we cannot switch to go1.19 because psiphon forks quic-go
and their fork's still not building using such a version of go.

Part of ooni/probe#2211.
@bassosimone bassosimone mentioned this issue Aug 22, 2022
Closed
@bassosimone bassosimone pinned this issue Aug 22, 2022
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 22, 2022
@bassosimone
fix: disable psiphon when building with go1.19
1264eb9 
Part of ooni/probe#2211.

See also ooni/probe#2222, which
describes the issue we have with psiphon.
This was referenced Aug 22, 2022
Merged
Closed
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 22, 2022
@bassosimone
fix: disable psiphon when building with go1.19 (#871)
208ffa2 
Part of ooni/probe#2211.

See also ooni/probe#2222, which
describes the issue we have with psiphon and go1.19.
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
chore: upgrade to go1.19.4
70f50ce 
This includes upgrading oocrypto and oohttp.

Closes ooni/probe#2211

See ooni/probe#2273
@bassosimone bassosimone mentioned this issue Jan 5, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Jan 5, 2023
@bassosimone
chore: upgrade to go1.19.4 (#1017)
ac2ec4b 
This includes upgrading oocrypto and oohttp.

Closes ooni/probe#2211

See ooni/probe#2273
@bassosimone bassosimone unpinned this issue Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
chore routine tasks that must be done, but require little active brain power ooni/probe-cli ooni/probe-engine priority/high user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade to go1.19.4 ooni/probe-cli
1 participant
@bassosimone