Fold class attributes into methods if used only once

open-contracting · Jun 2, 2020 · 59bcf35 · 59bcf35
1 parent d49fe4b
commit 59bcf35
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/kingfisher_scrapy/spiders/colombia.py b/kingfisher_scrapy/spiders/colombia.py
@@ -10,7 +10,6 @@
 
 class Colombia(LinksSpider):
     name = 'colombia'
-    sleep = 120 * 60
     next_page_formatter = parameters('page')
 
     def start_requests(self):
@@ -27,7 +26,7 @@ def start_requests(self):
     def retry(self, response, reason):
         url = response.request.url
         logging.info(reason.format(url=url, status=response.status))
-        time.sleep(self.sleep)
+        time.sleep(120 * 60)
         yield scrapy.Request(url, dont_filter=True, meta=response.request.meta)
 
     def parse(self, response):

diff --git a/kingfisher_scrapy/spiders/mexico_quien_es_quien.py b/kingfisher_scrapy/spiders/mexico_quien_es_quien.py
@@ -10,7 +10,6 @@
 class MexicoQuienEsQuien(BaseSpider):
     name = 'mexico_quien_es_quien'
     download_delay = 0.9
-    url = 'https://api.quienesquien.wiki/v2/contracts?limit={limit}&offset={offset}'
 
     def start_requests(self):
         yield scrapy.Request(
@@ -21,11 +20,12 @@ def start_requests(self):
 
     @handle_error
     def parse_list(self, response):
+        pattern = 'https://api.quienesquien.wiki/v2/contracts?limit={limit}&offset={offset}'
         limit = 1000
-        count = json.loads(response.text)['data'][0]['collections']['contracts']['count']
 
+        count = json.loads(response.text)['data'][0]['collections']['contracts']['count']
         for offset in range(ceil(count / limit)):
-            url = self.url.format(limit=limit, offset=offset * limit)
+            url = pattern.format(limit=limit, offset=offset * limit)
             yield self.build_request(url, formatter=parameters('offset'))
             if self.sample:
                 break