Add build_request and other helpers #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Add date_range_by_year and date_range_by_month helpers to normalize date loops. Update relevant spiders. Other changes to specific spiders: - australia: Use one instead of multiple date ranges - australia_nsw: Use the same ResultsPerPage for sample mode - chile_base: Fold get_year_month_until into start_requests to make logic easier to follow - chile_base: Move spider-specific logic into chile_compra_records and chile_compra_releases - chile_compra_bulk: Set the earliest start year to 2009 - colombia: Extract retry() method from parse() - moldova: Split into multiple callbacks - uganda_release: Let Scrapy's dupe filter skip duplicates - canada_montreal, chile_base, mexico_administracion_publica_federal, uk_contracts_finder: Make the code more generic for future method extraction Other small changes to multiple spiders: - Change some samples to be more recent - Use the same variable names consistently across spiders - Fold class attributes into methods if used only once - Put literal URLs on separate lines, to make reading and copying easier - Add comments to explain `kf_filename` value - Add comments to explain `formatter` value - Use f-strings if the format string is not reused - Use XPath instead of CSS selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #317