Add LinksSpiderError and update tests #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguilerapy
changed the title
jpmckinney
reviewed
Jun 23, 2020
kingfisher_scrapy/exceptions.py
Outdated
Comment on lines
17
to
18
| class LinksSpiderError(KingfisherScrapyError): | ||
| """Raised when a next link is invalid in LinksSpider""" |
There was a problem hiding this comment.
Let's use a more descriptive class name, since it's possible the LinksSpider will implement other exceptions in the future:
Suggested change
| class LinksSpiderError(KingfisherScrapyError): | |
| """Raised when a next link is invalid in LinksSpider""" | |
| class MissingNextLinkError(KingfisherScrapyError): | |
| """Raised when a next link is not found on the first page of results""" |
tests/test_links_spider.py
Outdated
|
|
||
| with pytest.raises(KingfisherScrapyError) as e: | ||
| assert spider.next_link(response_fixture(body='{"links": {"next": ""}}')) | ||
| meta = {'file_name': 'test', 'depth': 0} | ||
| assert spider.next_link(response_fixture(meta=meta, body=body)) |
There was a problem hiding this comment.
We can remove the assert here.
jpmckinney
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #412