Skip to content

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Aug 22, 2025

Fix #130

cjsha added 4 commits November 1, 2024 00:18
TODO:
- link tooltip content to definition of configuration and acquisition
  properties elsewhere
- this commit breaks light/dark mode dropdown mode - fix it
- move content out of html?
@cjsha cjsha requested a review from jonnew August 22, 2025 02:37
@cjsha cjsha requested a review from bparks13 September 18, 2025 19:54
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only comment I have is actually unrelated to this PR, so we can make another issue if necessary, or just leave it for now depending on what others think.

On the Library Reference page, I did not realize that the tags themselves were meant to be read as part of the sentence:

image

This could just be me, so feel free to ignore it, but I was reading them without reading the name of the tag, so the sentence was incomplete. It might make more sense to have these in a table, with the tag in one column and the description in the other. That way, the first paragraph would be slightly changed to read "Configuration properties...", with the visual indicator in a separate cell.

@cjsha
Copy link
Member Author

cjsha commented Sep 19, 2025

that's good input, it actually inspired me to make an additional change to separate Acquisition/Configuration properties and Device/Device Group properties into separate tables, because those are the two binary categorizations:

image

… into separate categories

for the purpose of implying that these are the two binary categorizations
@cjsha cjsha merged commit 298b777 into main Sep 19, 2025
3 checks passed
@cjsha cjsha deleted the issue-130 branch September 19, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add nice tooltip to property category badge

2 participants