Skip to content

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Mar 23, 2023

This PR

  • adds npm caching in all pipelines, with cache setup node takes 5s against 12s of before
    image

Related Issues

Fixes #310

Notes

since 14 is now too old, we decided that 16 was the best version to avoid breaking changes

Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #384 (ba2f06d) into main (818ec5c) will not change coverage.
The diff coverage is n/a.

❗ Current head ba2f06d differs from pull request most recent head 6ce13cd. Consider uploading reports for the commit 6ce13cd to get more accurate results

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          18       18           
  Lines        1326     1326           
  Branches      101      101           
=======================================
  Hits         1324     1324           
  Misses          2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RealAnna RealAnna marked this pull request as ready for review March 23, 2023 10:29
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna RealAnna force-pushed the feat/caching_for_pipelines branch from c003f1e to ba2f06d Compare March 23, 2023 15:55
Signed-off-by: realanna <anna.reale@dynatrace.com>
@toddbaert toddbaert self-requested a review March 23, 2023 15:59
Comment on lines +47 to +49
"engines": {
"node": ">=16"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for others. Previously the server SDK was requiring node 14, but that's very dead. We are upgrading to 16 here but not considering it a breaking change since the version is so old (even 16 is partially EOL).

https://endoflife.date/nodejs

@toddbaert toddbaert merged commit 55acc05 into open-feature:main Mar 23, 2023
toddbaert added a commit that referenced this pull request May 1, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](js-sdk-v1.1.1...js-sdk-v1.2.0)
(2023-05-01)


### Features

* add caching for pipelines
([#384](#384))
([55acc05](55acc05))


### Bug Fixes

* remove events exports from server
([#413](#413))
([7cac0c8](7cac0c8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
lukas-reining pushed a commit that referenced this pull request Jun 29, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action Cache
4 participants