Skip to content

fix: angular tests in main #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix: angular tests in main #1251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/angular/projects/angular-sdk/tsconfig.spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,19 @@
"vitest/globals",
"node"
],
"baseUrl": "../",
"paths": {
"angular": [
"./dist/angular"
]
],
"@openfeature/core": [ "../../shared/src" ],
"@openfeature/web-sdk": [ "../../web/src" ]
Comment on lines +9 to +15
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix.

},
"esModuleInterop": true,
"emitDecoratorMetadata": true
"emitDecoratorMetadata": true,
"noImplicitOverride": false,
"noPropertyAccessFromIndexSignature": false,
"strict": false
Comment on lines +18 to +21
Copy link
Member Author

@toddbaert toddbaert Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add these, because now the ng-test step compiles some code from the shared packages, and doesn't tolerate some stuff there without these.

Comment on lines +19 to +21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Disabling these TypeScript strictness checks (noImplicitOverride, noPropertyAccessFromIndexSignature, strict) can hide potential bugs and reduces the benefits of using TypeScript. It's better to address the underlying type errors directly rather than turning off the compiler checks. Please remove these overrides and fix any resulting compilation errors.

Copy link
Member Author

@toddbaert toddbaert Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true, but this is only for test code (tsconfig.spec.json); without this, we'd have to make a bunch of changes to @openfeature/core and @openfeature/web just to satisfy it's some of it's misconceptions.

},
"include": [
"src/**/*.spec.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/web/src/open-feature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ export class OpenFeatureAPI
const maybePromise = wrapper.provider.onContextChange(oldContext, newContext);

// only reconcile if the onContextChange method returns a promise
if (typeof maybePromise?.then === 'function') {
if (maybePromise && typeof maybePromise?.then === 'function') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only thing the ng-compiler was complaining about I could not ignore - obviously there's no real runtime change here, it just makes the compiler happy.

wrapper.incrementPendingContextChanges();
wrapper.status = this._statusEnumType.RECONCILING;
this.getAssociatedEventEmitters(domain).forEach((emitter) => {
Expand Down