fix: angular tests in main #1251

toddbaert · 2025-09-29T23:06:26Z

@lukas-reining this fixes the ongoing test compilation issue with ng-test we discussed today in main.

The reason you didn't see it locally is because if we have a compiled dist/ in ../web (the local version of @openfeature/web-sdk) it's resolved, but the main build doesn't have this at the point the tests run.

I could have fixed this by adding a compile step, but I think it's always better to run the tests against src/ of our local peers instead of dist/ (or else things get really weird and you can sometimes not realize you're testing against stale code)

This PR fixes this issue (confirmed by deleting the ../web dist locally, seeing the same errors, and then applying this fix).

NOTE: none of these changes impact prod code - just test configuration and one TS-only code change.

gemini-code-assist · 2025-09-29T23:06:41Z

Summary of Changes

Hello @toddbaert, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a recurring test compilation failure in the main branch affecting Angular tests. The fix involves reconfiguring the TypeScript specification file for the Angular SDK to correctly resolve local peer dependencies directly from their source code (src/) rather than relying on potentially missing or outdated compiled dist/ artifacts. This ensures a more robust and consistent testing environment, particularly in CI pipelines where compiled dependencies might not always be present. Additionally, a minor type assertion was added in the web SDK for clarity.

Highlights

Test Compilation Fix: Addresses an ongoing test compilation issue in the main branch specifically affecting Angular tests.
Dependency Resolution: Modifies tsconfig.spec.json to resolve local peer dependencies (@openfeature/core, @openfeature/web-sdk) directly from their src/ directories instead of relying on compiled dist/ artifacts, ensuring tests run against up-to-date source code.
TypeScript Configuration Update: Updates tsconfig.spec.json for the Angular SDK to include baseUrl, paths for local dependencies, and relaxes some strictness checks (noImplicitOverride, noPropertyAccessFromIndexSignature, strict: false) for the spec files.
Type Assertion in Web SDK: Adds a type assertion as Promise<void> to the maybePromise variable in packages/web/src/open-feature.ts to clarify its type in a conditional check.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

toddbaert · 2025-09-29T23:07:21Z

packages/angular/projects/angular-sdk/tsconfig.spec.json

+    "baseUrl": "../",
    "paths": {
      "angular": [
        "./dist/angular"
-      ]
+      ],
+      "@openfeature/core": [ "../../shared/src" ],
+      "@openfeature/web-sdk": [ "../../web/src" ]


This is the fix.

toddbaert · 2025-09-29T23:08:02Z

packages/angular/projects/angular-sdk/tsconfig.spec.json

+    "emitDecoratorMetadata": true,
+    "noImplicitOverride": false,
+    "noPropertyAccessFromIndexSignature": false,
+    "strict": false


I had to add these, because now the ng-test step compiles some code from the shared packages, and doesn't tolerate some stuff there without these.

gemini-code-assist

Code Review

This pull request aims to fix a test compilation issue by pointing the Angular tests to the src directory of local dependencies instead of dist. This is a good approach to ensure tests run against the latest code. However, my main concern is that several TypeScript strictness checks are disabled in tsconfig.spec.json to make the build pass. This can hide potential bugs and should be avoided. I've left a comment to remove these overrides and fix the underlying type errors instead. I also left a comment on a type assertion that seems to be a workaround for one of these type errors.

gemini-code-assist · 2025-09-29T23:08:03Z

packages/angular/projects/angular-sdk/tsconfig.spec.json

+    "noImplicitOverride": false,
+    "noPropertyAccessFromIndexSignature": false,
+    "strict": false


Disabling these TypeScript strictness checks (noImplicitOverride, noPropertyAccessFromIndexSignature, strict) can hide potential bugs and reduces the benefits of using TypeScript. It's better to address the underlying type errors directly rather than turning off the compiler checks. Please remove these overrides and fix any resulting compilation errors.

This is true, but this is only for test code (tsconfig.spec.json); without this, we'd have to make a bunch of changes to @openfeature/core and @openfeature/web just to satisfy it's some of it's misconceptions.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

toddbaert · 2025-09-29T23:15:10Z

packages/web/src/open-feature.ts


        // only reconcile if the onContextChange method returns a promise
-        if (typeof maybePromise?.then === 'function') {
+        if (maybePromise && typeof maybePromise?.then === 'function') {


This is the only thing the ng-compiler was complaining about I could not ignore - obviously there's no real runtime change here, it just makes the compiler happy.

🤖 I have created a release *beep* *boop* --- ## [0.0.17](angular-sdk-v0.0.16...angular-sdk-v0.0.17) (2025-09-30) ### 🐛 Bug Fixes * angular tests in main ([#1251](#1251)) ([f42011d](f42011d)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @openfeature/web-sdk bumped from ^1.5.0 to ^1.6.2 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de> Co-authored-by: Lukas Reining <lukas.reining@codecentric.de>

🤖 I have created a release *beep* *boop* --- ## [1.6.2](web-sdk-v1.6.1...web-sdk-v1.6.2) (2025-09-30) ### 🐛 Bug Fixes * angular tests in main ([#1251](#1251)) ([f42011d](f42011d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>

toddbaert requested review from a team as code owners September 29, 2025 23:06

toddbaert requested review from beeme1mr and lukas-reining September 29, 2025 23:06

toddbaert commented Sep 29, 2025

View reviewed changes

gemini-code-assist bot reviewed Sep 29, 2025

View reviewed changes

fix: angular tests in main

3d9ffe3

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

open-feature deleted a comment from gemini-code-assist bot Sep 29, 2025

toddbaert force-pushed the fix/ng-test branch from fc0421a to 3d9ffe3 Compare September 29, 2025 23:14

toddbaert commented Sep 29, 2025

View reviewed changes

toddbaert requested a review from juanparadox September 29, 2025 23:17

lukas-reining approved these changes Sep 30, 2025

View reviewed changes

lukas-reining merged commit f42011d into main Sep 30, 2025
12 checks passed

lukas-reining deleted the fix/ng-test branch September 30, 2025 06:57

This was referenced Sep 30, 2025

chore(main): release angular-sdk 0.0.17 #1253

Merged

chore(main): release web-sdk 1.6.2 #1252

Merged

openfeaturebot mentioned this pull request Sep 30, 2025

chore(main): release angular-sdk 0.0.10 #1255

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: angular tests in main #1251

fix: angular tests in main #1251

Uh oh!

toddbaert commented Sep 29, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Sep 29, 2025

Uh oh!

toddbaert Sep 29, 2025

Uh oh!

toddbaert Sep 29, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 29, 2025

Uh oh!

toddbaert Sep 29, 2025 •

edited

Loading

Uh oh!

toddbaert Sep 29, 2025

Uh oh!

Uh oh!

Uh oh!

fix: angular tests in main #1251

fix: angular tests in main #1251

Uh oh!

Conversation

toddbaert commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Sep 29, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

toddbaert Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

toddbaert Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

toddbaert Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

toddbaert Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

toddbaert commented Sep 29, 2025 •

edited

Loading

toddbaert Sep 29, 2025 •

edited

Loading

toddbaert Sep 29, 2025 •

edited

Loading