fix: fix publication #166
Merged
fix: fix publication #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
nicklasl
approved these changes
Aug 19, 2025
bencehornak
added a commit
to open-feature/kotlin-sdk-contrib
that referenced
this pull request
Aug 26, 2025
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR - Upgrades to the first Multiplatform-compatible Kotlin SDK version, which allows the CI to finally pass. - Sets up Dokka and publishing (using the [Gradle Maven Publish Plugin by vanniktech](https://vanniktech.github.io/gradle-maven-publish-plugin/)) similar to open-feature/kotlin-sdk#166 ### Follow-up Tasks Release Please can eventually be set up after this (#2). ### How to test <!-- if applicable, add testing instructions under this section --> The CI should pass for the first time. The publishing can be tested with `./gradlew publishToMavenLocal`. It should create the artifacts of the env-var provider under `~/.m2/repository/dev/openfeature/kotlin/contrib/providers/`. --------- Signed-off-by: Bence Hornák <bence.hornak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes the publication errors:
Notes
I have set up Dokka to generate docs in the typical Kotlin template. I've decided to adopt the recently released alpha v2 config syntax, because v1 will eventually be deprecated.
For packaging the Dokka HTML output as an old-school javadoc jar I've made use of the popular Gradle Maven Publish Plugin by vanniktech, which is used by Ktor and OkHttp just two mention two popular ones.
How to test
Dokka
Execute
It will place the generated docs in
kotlin-sdk/build/dokka. You can also double check that the(source)links point to the right GitHub URLs.Local publication
If you have the code signing locally configured, you can execute
./gradlew publishToMavenLocal. This will place the generated files under/home/bence/.m2/repository/dev/openfeature/.(If you don't have code signing, comment out
signAllPublications()inkotlin-sdk/build.gradle.kts)For me it generated the following files, hopefully everything that is required by the Sonatype repository:
If you extract the javadoc jars, they should contain the html docs.