Skip to content

feat: Multi provider impl #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Sep 3, 2025
Merged

feat: Multi provider impl #168

merged 25 commits into from
Sep 3, 2025

Conversation

PenguinDan
Copy link
Contributor

@PenguinDan PenguinDan commented Aug 20, 2025 •
edited
Loading

This PR

Multi Provider implementation according to the specifications outlined in https://openfeature.dev/specification/appendix-a/#multi-provider

  • Does not implement support for hooks for the moment

Related Issues

Fixes #149

Notes

Work that still needs to be done

  • Need to go through the specifications one more time to make sure the implementation aligns with it

Follow-up Tasks

  1. Add a logging tool?
  2. Event Type enhancements Missing OpenFeature Events types. #107
  3. Documentation updates

How to test

Updated the sample application to utilize a multi provider

@PenguinDan PenguinDan changed the title Multi provider impl feat: Multi provider impl Aug 20, 2025
@PenguinDan
Multi provider impl draft
af65a59 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Ktlint
79f59ba 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Try emit initial state for Multi provider
6127d68 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Shared flow should always have content
2142879 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Add tests
c6f3a8f 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Update multi provider strategy to better align with Open Feature specs
f2f415a 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Add original metadata and allow all providers to shutdown
199236c 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Add default reason to default value in First Match Strategy
38fac8c 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Remove json dependency and update ProviderMetadata
48033c5 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Align to Event spec
4fa33eb 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Ktlint
d5f5546 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan PenguinDan marked this pull request as ready for review August 22, 2025 17:11
@PenguinDan
Update API dumps for multiprovider and ProviderMetadata changes
8d8cbec 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Use Lazy and ktlint
3818a11 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@jescriba jescriba mentioned this pull request Aug 25, 2025
Merged
@PenguinDan
Add TODO once EventDetails have been added
f834a43 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
bencehornak
bencehornak requested changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@bencehornak bencehornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contributions, @PenguinDan, they look very promising! Nothing serious, only minor findings from my side!

@PenguinDan
PR comments; remove redundant comments, fix test definitions, move st…
c299717 
…rategy into MultiProvider

Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Return an error result for FirstSuccessfulStrategy rather than throwing
2305056 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Revert sample app changes
70a892d 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Add README documentation for Multiprovider
6fe18eb 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Lets favor not throwing in the FirstMatchStrategy also
870ae07 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan
Update tests to represent to non-throwing pattern and api dump
5472c08 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan PenguinDan requested a review from bencehornak August 26, 2025 17:50
@PenguinDan
Kotlin Format
7df6772 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
bencehornak
bencehornak reviewed Aug 30, 2025
View reviewed changes
Copy link
Contributor

@bencehornak bencehornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, going to the right direction!

PenguinDan and others added 2 commits August 30, 2025 16:05
@PenguinDan @bencehornak
Update kotlin-sdk/src/commonMain/kotlin/dev/openfeature/kotlin/sdk/mu…
2cc75c5 
…ltiprovider/FirstSuccessfulStrategy.kt

Co-authored-by: Bence Hornák <bence.hornak@gmail.com>
Signed-off-by: Daniel Kim <daniel.seunkim@gmail.com>
@PenguinDan
Update multi provider readme
e71d448 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
@PenguinDan PenguinDan requested a review from bencehornak August 30, 2025 23:26
@PenguinDan
Merge branch 'main' into MultiProvider-Impl
c4c49db
@PenguinDan
API dump
f540783 
Signed-off-by: penguindan <daniel.seunkim@gmail.com>
nicklasl
nicklasl approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@nicklasl nicklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting work! Thanks for this!

@PenguinDan
Copy link
Contributor Author

@nicklasl or @bencehornak Ah, looks like I don't have perms to get this merged in

Can I get some help there

@bencehornak bencehornak merged commit 807fcc1 into open-feature:main Sep 3, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 31, 2025
Merged
@bencehornak
Copy link
Contributor

Thanks for your work @PenguinDan !

@PenguinDan PenguinDan deleted the MultiProvider-Impl branch September 4, 2025 21:15
fabriziodemaria pushed a commit to open-feature/swift-sdk that referenced this pull request Sep 15, 2025
@jescriba
feat: add multiprovider (#78)
869b90a 
## This PR
- Adds multiprovider with `FirstMatchStrategy` and
`FirstSuccessfulStrategy` implementations
- Effectively is a port of this kotlin-sdk update:
open-feature/kotlin-sdk#168 to swift

### Related Issues
#68

### Follow-up Tasks
- Update documentation

### How to test
- Adds unit test coverage, but open to ideas on additional ways to test!

---------

Signed-off-by: jescriba <joshua.escribano@includedhealth.com>
Signed-off-by: Joshua E. <escribirajoshua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mr beeme1mr beeme1mr left review comments

@nicklasl nicklasl nicklasl approved these changes

@bencehornak bencehornak bencehornak approved these changes

@jonathannorris jonathannorris Awaiting requested review from jonathannorris

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

@toddbaert toddbaert Awaiting requested review from toddbaert

@lukas-reining lukas-reining Awaiting requested review from lukas-reining

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement Multiprovider

4 participants

@PenguinDan @bencehornak @beeme1mr @nicklasl