fix: setProviderAndWait does not hang on ProviderError #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
force-pushed
the
wait-on-provider-error
branch
from
cb840b1 to
97efa1f
Compare
Signed-off-by: Fabrizio Demaria <fdema@spotify.com>
fabriziodemaria
force-pushed
the
wait-on-provider-error
branch
4 times, most recently
from
edd81d4 to
3f12d8d
Compare
nicklasl
reviewed
Jan 8, 2024
| try { | ||
| provider.initialize(context) | ||
| } catch (e: Throwable) { | ||
| // This should never happen |
Member
There was a problem hiding this comment.
Can we rephrase this to
This is not allowed to happen.
and maybe reference the spec?
Contributor
Author
There was a problem hiding this comment.
I don't think there is anything about this in the Spec. It's this specific implementation that expects the Provider to never throw and rather reads ProviderError events from the Provider.
The Java SDK, for example, works in the opposite way and expects the Provider to throw in case of errors
Signed-off-by: Fabrizio Demaria <fdema@spotify.com>
Signed-off-by: Fabrizio Demaria <fdema@spotify.com>
Signed-off-by: Fabrizio Demaria <fdema@spotify.com>
fabriziodemaria
force-pushed
the
wait-on-provider-error
branch
from
4b3de76 to
59f537f
Compare
nicklasl
reviewed
Jan 8, 2024
| private var eventHandler = EventHandler(dispatcher) | ||
| override fun initialize(initialContext: EvaluationContext?) { | ||
| CoroutineScope(dispatcher).launch { | ||
| delay(10000) |
nicklasl
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
setContextAndWaitshouldn't hang if the Provider fails the initalization phase for some reason.Related Issues
N/A
Follow-up Tasks
Similar logic will need to be added to setEvaluationContext
How to test
Added unit tests