Skip to content

Conversation

@tcarrio
Copy link
Member

@tcarrio tcarrio commented Feb 12, 2023

This PR

  • fixes the interface for provider's resolveObject method

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: Tom Carrio <tom@carrio.dev>
@tcarrio tcarrio force-pushed the fix/provider-resolve-object-interface branch from 1641a5f to 57162dd Compare February 12, 2023 03:13
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #78 (57162dd) into main (573884e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #78   +/-   ##
=========================================
  Coverage     95.19%   95.19%           
  Complexity      227      227           
=========================================
  Files            40       40           
  Lines           583      583           
=========================================
  Hits            555      555           
  Misses           28       28           
Impacted Files Coverage Δ
src/implementation/provider/AbstractProvider.php 66.66% <ø> (ø)
src/implementation/provider/NoOpProvider.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tcarrio tcarrio merged commit d0f9ea9 into main Feb 12, 2023
tcarrio pushed a commit that referenced this pull request Feb 12, 2023
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](1.4.0...2.0.0)
(2023-02-12)


### ⚠ BREAKING CHANGES

* provider resolveObject interface
([#78](#78))

### Bug Fixes

* provider resolveObject interface
([#78](#78))
([d0f9ea9](d0f9ea9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants