Add tests for missing methods #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-mpi/ompi#3402 added missing Java binding methods to Open MPI. These test programs correspond to those methods. Signed-off-by: Tsubasa Yanagibashi <fj2505dt@aa.jp.fujitsu.com>
|
@nrgraham23, @yanagibashi is my colleague. Could you check and pull this? @hppritcha, You asked me on the F2F OMPI dev meeting last month which Java version Fujitsu use for post-K computer. We plan to use upcoming Java 9. |
|
Sorry I haven't gotten to this yet. Ill give it a look after work tonight. |
|
I looked through the code and it all looks good to me. I don't have a setup to test it though. @hppritcha could you give this a try and merge it if you are satisfied? |
|
@hppritcha Is this OK? I don't have a permission to pull it to |
|
@kawashima-fj you should be able to merge now. Thanks for the new tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-mpi/ompi#3402 added missing Java binding methods to Open MPI.
These test programs correspond to those methods.
Signed-off-by: Tsubasa Yanagibashi fj2505dt@aa.jp.fujitsu.com