mpi/java: Add missing Java binding methods #3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add the following methods.
| Language-indep. notation | Java binding |
| ------------------------ | ----------------------- |
| MPI_WIN_GET_ERRHANDLER | mpi.Win.getErrhandler |
| MPI_FILE_SET_ERRHANDLER | mpi.File.setErrhandler |
| MPI_FILE_GET_ERRHANDLER | mpi.File.getErrhandler |
| MPI_COMM_CALL_ERRHANDLER | mpi.Comm.callErrhandler |
| MPI_FILE_CALL_ERRHANDLER | mpi.File.callErrhandler |
| MPI_FILE_IREAD_AT_ALL | mpi.File.iReadAtAll |
| MPI_FILE_IWRITE_AT_ALL | mpi.File.iWriteAtAll |
| MPI_FILE_IREAD_ALL | mpi.File.iReadAll |
| MPI_FILE_IWRITE_ALL | mpi.File.iWriteAll |
| MPI_FILE_GET_ATOMICITY | mpi.File.getAtomicity |
`MPI_FILE_I{READ,WRITE}(_AT)_ALL` routines are added in MPI-3.1.
I don't know why other methods were missing.
Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
Probably setting `MPI_ERRORS_RETURN` is unintentional. Probably... Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
|
The test failure was git permissions issues that have been fixed. Trying again... bot:ompi:retest |
|
autoreconf (aclocal) timeout? |
|
@kawashima-fj Could you also add unit tests to https://github.com/open-mpi/ompi-java-test for these methods? |
|
bot:ompi:retest |
|
@nrgraham23 I have simple unit test programs but they don't fit to the manner of https://github.com/open-mpi/ompi-java-test (use of And hopefully I'll add more tests for existing methods. |
yanagibashi
added a commit
to yanagibashi/ompi-java-test
that referenced
this pull request
Aug 10, 2017
open-mpi/ompi#3402 added missing Java binding methods to Open MPI. These test programs correspond to those methods. Signed-off-by: Tsubasa Yanagibashi <fj2505dt@aa.jp.fujitsu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add the following methods.
MPI_FILE_I{READ,WRITE}(_AT)_ALLroutines are added in MPI-3.1.I don't know why other methods were missing.
Additionally, existing
mpi.Win.setErrhandleris corrected.