Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now there is feedback when saving or updating workspace settings #3184

Merged

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Apr 13, 2024

Description

Related Tickets & Documents

Fixes #3181

Mobile & Desktop Screenshots/Recordings

Storybook

CleanShot 2024-04-13 at 13 22 26

Updating a Workspace

Before

CleanShot 2024-04-13 at 13 29 34

After

CleanShot 2024-04-13 at 13 29 07

Creating a Workspace

Before

CleanShot 2024-04-13 at 13 31 05

After

CleanShot 2024-04-13 at 13 32 10

Steps to QA

Creating a Workspace

  1. Create a new workspace
  2. Fill out the required info.
  3. When the Create Workspace button is clicked, notice the text of the button changes and has a spinner.
  4. The workspace is created

Updating a workspace

  1. Go to /workspace/some-workspace-id/settings
  2. Change at least one thing in the workspace setting.
  3. When the Update Workspace button is clicked, notice the text of the button changes and has a spinner.
  4. The workspace is updated.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 1b6782b
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/661fd70a52e29e0008a8e54e
😎 Deploy Preview https://deploy-preview-3184--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 1b6782b
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/661fd70a84604c0008b30685
😎 Deploy Preview https://deploy-preview-3184--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested a review from a team April 13, 2024 17:30
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isabensusan isabensusan self-requested a review April 17, 2024 13:58
Copy link
Member

@isabensusan isabensusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎨 😄

@nickytonline nickytonline merged commit 43784b2 into beta Apr 17, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/fix-update-save-workspace-settings-feedback branch April 17, 2024 14:09
open-sauced bot pushed a commit that referenced this pull request Apr 17, 2024
## [2.19.0-beta.10](v2.19.0-beta.9...v2.19.0-beta.10) (2024-04-17)

### 🐛 Bug Fixes

* now links in collapsed sidebar no longer receive focus ([#3187](#3187)) ([5b05ace](5b05ace))
* now there is feedback when saving or updating workspace settings ([#3184](#3184)) ([43784b2](43784b2))
* quick fix StarSearch response ([#3194](#3194)) ([0c2847e](0c2847e))
* removed deprecated list pages ([#3197](#3197)) ([fa14557](fa14557))
open-sauced bot pushed a commit that referenced this pull request Apr 17, 2024
## [2.19.0](v2.18.0...v2.19.0) (2024-04-17)

### 🐛 Bug Fixes

* fixed star search URL for SEO ([#3218](#3218)) ([69f8d67](69f8d67))
* now links in collapsed sidebar no longer receive focus ([#3187](#3187)) ([5b05ace](5b05ace))
* now repo page OG images are corrext for production ([#3179](#3179)) ([772c7b5](772c7b5))
* now there is feedback when saving or updating workspace settings ([#3184](#3184)) ([43784b2](43784b2))
* quick fix StarSearch response ([#3194](#3194)) ([0c2847e](0c2847e))
* remove console.info call from mutateHandler in AppSidebar component ([#3185](#3185)) ([96b63d7](96b63d7))
* removed activity column from contributor grid ([#3206](#3206)) ([4b11168](4b11168))
* removed deprecated list pages ([#3197](#3197)) ([fa14557](fa14557))
* update logic for most used languages to match contributor profile ([#3205](#3205)) ([e8f8a75](e8f8a75))
* updated styles of create insights links in sidebar ([#3173](#3173)) ([6c0c5ce](6c0c5ce))

### 🍕 Features

* add link from Repo pages to GitHub ([#3177](#3177)) ([f4e1de4](f4e1de4))
* add support for blogpost from generic platforms  ([#2555](#2555)) ([8ca6f25](8ca6f25))
* basic implementation of StarSearch ([#3162](#3162)) ([0086134](0086134))
* change repo links from github to repo pages ([#3178](#3178)) ([506dde2](506dde2))
* Create robots.txt ([#3183](#3183)) ([751c561](751c561))
* created the workspace activity page with a pull requests table ([#3147](#3147)) ([9f65b9c](9f65b9c))
* rename cumulative to history in Repo pages ([#3195](#3195)) ([8a33e24](8a33e24))
* render markdown for `/starsearch` responses ([#3204](#3204)) ([49ce317](49ce317))
* styling `/starsearch` ([#3211](#3211)) ([5e4c037](5e4c037))
* switch [#100](#100 banner with Workspaces banner on feed page ([#3216](#3216)) ([417e98b](417e98b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No feedback while saving workspace changes
3 participants