-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: basic implementation of StarSearch #3162
Conversation
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Is that in the deploy preview or on local? Locally it's probably because of React Strict mode, but it should only show up once in the deploy preview. |
On local. I guess that's the history repeating because of strict mode? Hadn't occurred to me. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @zeucapua!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works. Let's merge. I noted a weird UX pattern in regards to disabling the form, but fine if that gets added later in some polish PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
Works great. I had a question before about how we get back to the first page with the cards
## [2.19.0-beta.1](v2.18.0...v2.19.0-beta.1) (2024-04-11) ### 🍕 Features * basic implementation of StarSearch ([#3162](#3162)) ([0086134](0086134))
## [2.19.0](v2.18.0...v2.19.0) (2024-04-17) ### 🐛 Bug Fixes * fixed star search URL for SEO ([#3218](#3218)) ([69f8d67](69f8d67)) * now links in collapsed sidebar no longer receive focus ([#3187](#3187)) ([5b05ace](5b05ace)) * now repo page OG images are corrext for production ([#3179](#3179)) ([772c7b5](772c7b5)) * now there is feedback when saving or updating workspace settings ([#3184](#3184)) ([43784b2](43784b2)) * quick fix StarSearch response ([#3194](#3194)) ([0c2847e](0c2847e)) * remove console.info call from mutateHandler in AppSidebar component ([#3185](#3185)) ([96b63d7](96b63d7)) * removed activity column from contributor grid ([#3206](#3206)) ([4b11168](4b11168)) * removed deprecated list pages ([#3197](#3197)) ([fa14557](fa14557)) * update logic for most used languages to match contributor profile ([#3205](#3205)) ([e8f8a75](e8f8a75)) * updated styles of create insights links in sidebar ([#3173](#3173)) ([6c0c5ce](6c0c5ce)) ### 🍕 Features * add link from Repo pages to GitHub ([#3177](#3177)) ([f4e1de4](f4e1de4)) * add support for blogpost from generic platforms ([#2555](#2555)) ([8ca6f25](8ca6f25)) * basic implementation of StarSearch ([#3162](#3162)) ([0086134](0086134)) * change repo links from github to repo pages ([#3178](#3178)) ([506dde2](506dde2)) * Create robots.txt ([#3183](#3183)) ([751c561](751c561)) * created the workspace activity page with a pull requests table ([#3147](#3147)) ([9f65b9c](9f65b9c)) * rename cumulative to history in Repo pages ([#3195](#3195)) ([8a33e24](8a33e24)) * render markdown for `/starsearch` responses ([#3204](#3204)) ([49ce317](49ce317)) * styling `/starsearch` ([#3211](#3211)) ([5e4c037](5e4c037)) * switch [#100](#100 banner with Workspaces banner on feed page ([#3216](#3216)) ([417e98b](417e98b))
Description
Implements a basic input output for
/starsearch
, parsing aReadableStream
from the API endpoint/star-search/stream
and displaying it to the UI with a typewriter effect. There are still some issues with parsing since some chunks are part of another word and there's no way we can determine that in the front end (for now). See video for example ("priorit ized" or "maintain ers").Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2024-04-11.at.12.45.47.PM.mov
Steps to QA
star_search
feature flag.What is GitHub pull request used for?
Tier (staff will fill in)
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?