fix: now repo page OG images are corrext for production #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IC_BASE_URL isn't set
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
commented
Apr 13, 2024
nickytonline
changed the title
brandonroberts
approved these changes
Apr 15, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
## [2.19.0-beta.8](v2.19.0-beta.7...v2.19.0-beta.8) (2024-04-16) ### 🐛 Bug Fixes * now repo page OG images are corrext for production ([#3179](#3179)) ([772c7b5](772c7b5))
open-sauced bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
## [2.19.0](v2.18.0...v2.19.0) (2024-04-17) ### 🐛 Bug Fixes * fixed star search URL for SEO ([#3218](#3218)) ([69f8d67](69f8d67)) * now links in collapsed sidebar no longer receive focus ([#3187](#3187)) ([5b05ace](5b05ace)) * now repo page OG images are corrext for production ([#3179](#3179)) ([772c7b5](772c7b5)) * now there is feedback when saving or updating workspace settings ([#3184](#3184)) ([43784b2](43784b2)) * quick fix StarSearch response ([#3194](#3194)) ([0c2847e](0c2847e)) * remove console.info call from mutateHandler in AppSidebar component ([#3185](#3185)) ([96b63d7](96b63d7)) * removed activity column from contributor grid ([#3206](#3206)) ([4b11168](4b11168)) * removed deprecated list pages ([#3197](#3197)) ([fa14557](fa14557)) * update logic for most used languages to match contributor profile ([#3205](#3205)) ([e8f8a75](e8f8a75)) * updated styles of create insights links in sidebar ([#3173](#3173)) ([6c0c5ce](6c0c5ce)) ### 🍕 Features * add link from Repo pages to GitHub ([#3177](#3177)) ([f4e1de4](f4e1de4)) * add support for blogpost from generic platforms ([#2555](#2555)) ([8ca6f25](8ca6f25)) * basic implementation of StarSearch ([#3162](#3162)) ([0086134](0086134)) * change repo links from github to repo pages ([#3178](#3178)) ([506dde2](506dde2)) * Create robots.txt ([#3183](#3183)) ([751c561](751c561)) * created the workspace activity page with a pull requests table ([#3147](#3147)) ([9f65b9c](9f65b9c)) * rename cumulative to history in Repo pages ([#3195](#3195)) ([8a33e24](8a33e24)) * render markdown for `/starsearch` responses ([#3204](#3204)) ([49ce317](49ce317)) * styling `/starsearch` ([#3211](#3211)) ([5e4c037](5e4c037)) * switch [#100](#100 banner with Workspaces banner on feed page ([#3216](#3216)) ([417e98b](417e98b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, localhost is only used if
NEXT_PUBLIC_BASE_URLisn't set for the repository page repo image.Related Tickets & Documents
Fixes #3180
Relates to #3117
Mobile & Desktop Screenshots/Recordings
Steps to QA
<head>section.Tier (staff will fill in)
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?