Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove console.info call from mutateHandler in AppSidebar component #3185

Conversation

francisko-rezende
Copy link
Contributor

@francisko-rezende francisko-rezende commented Apr 13, 2024

Description

This PR removes a console.info call from the mutateHandler function in the AppSidebar component and a comment used to disable eslint's no console rule for the line that had such call. This PR also removes the argument "event" from mutateHandler as it was no longer being used after deleting the console.info call.

Related Tickets & Documents

Fixes #3182

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit f12205e
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/661b1328298f1b00085ff289
😎 Deploy Preview https://deploy-preview-3185--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit f12205e
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/661b1328ab73870008789f09
😎 Deploy Preview https://deploy-preview-3185--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@nickytonline nickytonline requested a review from a team April 14, 2024 00:49
@nickytonline nickytonline changed the title chore: delete console.info call from mutateHandler in AppSidebar fix: remove console.info call from mutateHandler in AppSidebar component Apr 14, 2024
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @francisko-rezende and congrats on your first pull request to the OpenSauced app repository!

🚢

Copy link
Contributor

@NsdHSO NsdHSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit 96b63d7 into open-sauced:beta Apr 15, 2024
23 checks passed
open-sauced bot pushed a commit that referenced this pull request Apr 15, 2024
## [2.19.0-beta.6](v2.19.0-beta.5...v2.19.0-beta.6) (2024-04-15)

### 🐛 Bug Fixes

* remove console.info call from mutateHandler in AppSidebar component ([#3185](#3185)) ([96b63d7](96b63d7))
open-sauced bot pushed a commit that referenced this pull request Apr 17, 2024
## [2.19.0](v2.18.0...v2.19.0) (2024-04-17)

### 🐛 Bug Fixes

* fixed star search URL for SEO ([#3218](#3218)) ([69f8d67](69f8d67))
* now links in collapsed sidebar no longer receive focus ([#3187](#3187)) ([5b05ace](5b05ace))
* now repo page OG images are corrext for production ([#3179](#3179)) ([772c7b5](772c7b5))
* now there is feedback when saving or updating workspace settings ([#3184](#3184)) ([43784b2](43784b2))
* quick fix StarSearch response ([#3194](#3194)) ([0c2847e](0c2847e))
* remove console.info call from mutateHandler in AppSidebar component ([#3185](#3185)) ([96b63d7](96b63d7))
* removed activity column from contributor grid ([#3206](#3206)) ([4b11168](4b11168))
* removed deprecated list pages ([#3197](#3197)) ([fa14557](fa14557))
* update logic for most used languages to match contributor profile ([#3205](#3205)) ([e8f8a75](e8f8a75))
* updated styles of create insights links in sidebar ([#3173](#3173)) ([6c0c5ce](6c0c5ce))

### 🍕 Features

* add link from Repo pages to GitHub ([#3177](#3177)) ([f4e1de4](f4e1de4))
* add support for blogpost from generic platforms  ([#2555](#2555)) ([8ca6f25](8ca6f25))
* basic implementation of StarSearch ([#3162](#3162)) ([0086134](0086134))
* change repo links from github to repo pages ([#3178](#3178)) ([506dde2](506dde2))
* Create robots.txt ([#3183](#3183)) ([751c561](751c561))
* created the workspace activity page with a pull requests table ([#3147](#3147)) ([9f65b9c](9f65b9c))
* rename cumulative to history in Repo pages ([#3195](#3195)) ([8a33e24](8a33e24))
* render markdown for `/starsearch` responses ([#3204](#3204)) ([49ce317](49ce317))
* styling `/starsearch` ([#3211](#3211)) ([5e4c037](5e4c037))
* switch [#100](#100 banner with Workspaces banner on feed page ([#3216](#3216)) ([417e98b](417e98b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Remove eslint-disable-next-line comment that is no longer necessary
4 participants